DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: dev@dpdk.org, maxime coquelin <maxime.coquelin@redhat.com>,
	Yuhui Jiang <yujiang@redhat.com>, Wei Shi <wshi@redhat.com>
Subject: Re: [dpdk-dev] Problems running netvsc multiq
Date: Fri, 7 Dec 2018 09:31:06 -0800	[thread overview]
Message-ID: <20181207093106.0d070d4b@xeon-e3> (raw)
In-Reply-To: <1544181343.5629.1.camel@redhat.com>

On Fri, 07 Dec 2018 13:15:43 +0200
Mohammed Gamal <mgamal@redhat.com> wrote:

> On Wed, 2018-12-05 at 14:32 -0800, Stephen Hemminger wrote:
> > The problem is a regression in 4.20 kernel. Bisecting now.  
> 
> I was bisecting the kernel and the change that seems to introduce this
> regression is this one:
> 
> commit ae6935ed7d424ffa74d634da00767e7b03c98fd3
> Author: Stephen Hemminger <stephen@networkplumber.org>
> Date:   Fri Sep 14 09:10:17 2018 -0700
> 
>     vmbus: split ring buffer allocation from open
>     
>     The UIO driver needs the ring buffer to be persistent(reused)
>     across open/close. Split the allocation and setup of ring buffer
>     out of vmbus_open. For normal usage vmbus_open/vmbus_close there
>     are no changes; only impacts uio_hv_generic which needs to keep
>     ring buffer memory and reuse when application restarts.
>     
>     Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 

Yes, this is the kernel problem that introduces the problem.
The issue is actually back in the unbind logic.  When device is unbound
from the netvsc driver all the subchannels aren't cleaned up.

Still debugging.

  reply	other threads:[~2018-12-07 17:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 11:04 Mohammed Gamal
2018-11-30 18:27 ` Stephen Hemminger
2018-11-30 19:06   ` Mohammed Gamal
2018-12-04 16:48     ` Stephen Hemminger
2018-12-04 16:56       ` Mohammed Gamal
2018-12-05 22:12         ` Stephen Hemminger
2018-12-05 22:32         ` Stephen Hemminger
2018-12-07 11:15           ` Mohammed Gamal
2018-12-07 17:31             ` Stephen Hemminger [this message]
2018-12-07 19:18             ` Stephen Hemminger
2018-12-08  8:10               ` Mohammed Gamal
2018-11-30 20:24 ` [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation Stephen Hemminger
2018-12-03  6:02   ` Mohammed Gamal
2018-12-03 16:48     ` Stephen Hemminger
2018-12-04 11:59       ` Mohammed Gamal
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 1/4] " Stephen Hemminger
2018-12-05 22:11   ` [dpdk-dev] [PATCH v2 2/4] net/netvsc: enable SR-IOV Stephen Hemminger
2018-12-05 22:11   ` [dpdk-dev] [PATCH v2 3/4] net/netvsc: disable multi-queue on older servers Stephen Hemminger
2018-12-05 22:11   ` [dpdk-dev] [PATCH v2 4/4] bus/vmbus: debug subchannel setup Stephen Hemminger
2018-12-19  2:02   ` [dpdk-dev] [PATCH v2 1/4] bus/vmbus: fix race in sub channel creation Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207093106.0d070d4b@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mgamal@redhat.com \
    --cc=wshi@redhat.com \
    --cc=yujiang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).