From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 53BD75F2D for ; Mon, 10 Dec 2018 17:01:12 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id c123so5615298pfb.0 for ; Mon, 10 Dec 2018 08:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uS4v+TZaiSOtThd+yhGGYrT+WWg3X+iftZx7FZgwoCc=; b=A235dYA9AEGJqas+dCvvZgF0Zo8gIqJ14CKHGbmup8nQEUlMGJfaLGZShiuvS9cnm8 JeJr/rSvlUIs2KuYgCNNnO3S3/AcCqwE3ec1Ki/qCz4RvO8A9ZiPO3fRB6H3fXOm2HtB jvRKv1bjijlEyAMQ7Qu8yn/753kMPh5UfJiZd5RklY9elvkL85SEMMSpGVyEQuZUzC87 jnHUtEfZwvt3/vGm5ruOxoGEuOoWXk6iTPYtzgIZdmfXsfW3DXeoiNuiMKpHwqMaUhVe obLLqdVSzRza5o6oa66V9TddLChUxaCSP1FrAL0H/eJM6xBtsjUm+KJyxv6ugHoiPivy RT2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uS4v+TZaiSOtThd+yhGGYrT+WWg3X+iftZx7FZgwoCc=; b=DY+DoW/iQO30eaw8ujYNPQvv3lEd/oF9/MQANwA/weqrx+cmFdI0ctMs59Q2AcMCLL VLreBlkN4xoOuLJsZ7mW/RcAtdE8HtPjIxZuBdqvoeiZdhC7OV8R9taO15VaJrzQdjTu 7IuWPjqX0+qEdsYCER8QZtc1/jBUu1839Z85mJTr0GuFC6w8H8nHwl2szn5UZunXOftl Tu7HiKK4OAkmahNuz+tdgntbBT9GtxNbKfX5O8D7anyl7Q8OBK+6Vkt2GJw/zKtyyIhp U8JdhBe/8j3Trik5GPip8vVGCAr2EbeWXwAIACQN66VBquhJbdYx7Lawf56+x/tkOmTw DhEA== X-Gm-Message-State: AA+aEWZpKSUQdtMa/k2bTt5FptWatVCrIke6kOtg1vEOFZCKxNazU5GD FK/jdf/nTPbM6jLurv4Pif1/tw== X-Google-Smtp-Source: AFSGD/XsWrBY3ygHIVRcrMgJs8bmeOCLL8p5NaEey9dGwlSBdsGuhVWZHZMqBSGZu4tIBFO9ubMPuA== X-Received: by 2002:a62:113:: with SMTP id 19mr12659525pfb.176.1544457671419; Mon, 10 Dec 2018 08:01:11 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z191sm13675455pgd.74.2018.12.10.08.01.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 08:01:11 -0800 (PST) Date: Mon, 10 Dec 2018 08:01:09 -0800 From: Stephen Hemminger To: "Rao, Nikhil" Cc: "Dumitrescu, Cristian" , "Singh, Jasvinder" , "dev@dpdk.org" Message-ID: <20181210080109.617902f1@xeon-e3> In-Reply-To: <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com> References: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com> <20181128221245.017eadcf@xeon-e3> <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 16:01:12 -0000 On Mon, 10 Dec 2018 05:43:37 +0000 "Rao, Nikhil" wrote: > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Thursday, November 29, 2018 11:43 AM > > To: Rao, Nikhil > > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue > > weight > > > > On Thu, 29 Nov 2018 11:24:42 +0530 > > Nikhil Rao wrote: > > > > > RED queue weight is currently specified as a negated log of 2. > > > > > > Add support for RED queue weight to be specified in double precision > > > and TM capability flags for double precision and negated log2 RED > > > queue weight support. > > > > > > Signed-off-by: Nikhil Rao > > > > Since this is an ABI break anyway, why not just commit to the new format? > > Hi Stephen, > > Can you please provide more detail on your comment ? are you suggesting replacing the wq_log2/wq_dp with a double ? > > Thanks, > Nikhil My comment is that since you are changing a structure layout, which would break existing users; why not go farther and just fix the API to a better version. I don't think any projects use this code anyway, see my talk (https://github.com/shemminger/dpdk-metrics). Isn't floating point going to be expensive. Or is it only during the setup process, not enqueue/dequeue.