Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

[Hyong Youb Kim <hyonkim@cisco.com>]

On Tue, Dec 11, 2018 at 04:31:50PM +0000, Varghese, Vipin wrote:
> Hi Hyong,
> 
> snipped
> > > Hi Hyong,
> > >
> > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been
> > updated too?'(Section 16 under Network Interface Controller).
> > > a. If yes is it ok to link the patchwork in comment section?
> > > b. If no, will you be updating the documentation?
> > >
> > 
> > Vipin,
> > 
> > I am not planning to update the enic guide, as these changes (fw version string,
> > multicast filtering) do not need additional explanations. Did you have
> > something else in mind?
> 
> Thanks for sharing the information.
> 
> In my humble opinion
> 
> In documentation section '16.13. Supported features' states 'Unicast, multicast and broadcast transmission and reception'. So multicast 'filtering' to be added as supported feature or not is upto the individual for the PMD. But as you shared the information ' I am not planning to update the enic guide' I will leave this open to others for comment.

I see what you mean now. Sure, I will send another patch to update
that section later. As is, it is really a duplicate of
doc/guides/nics/features. Not sure if we want to keep maintaining two
copies of the same information.

> 
> Question: Will there update for test cases for mac filtering been added? Reason the patch set is not covering test case addition. 
> 

We have an internal DTS based test case for multicast filtering. Do we
need to mention test cases in commit logs now? I am a bit confused
where this question is coming from..

-Hyong