From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id CCBD92C12 for ; Tue, 11 Dec 2018 17:40:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1608; q=dns/txt; s=iport; t=1544546415; x=1545756015; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ahyTXLsKiKjzp5pRiGVzOIDZH1qNBRimjAGmIawPF6Y=; b=KsNhGNvl7tTld+jamHzaROMCMNsjiwm6vA4dfnbw0iVT4tfmPiL+ljvk k73XPnh901rHrw+Hb2wVS5L5FlPCKtwiVVY5R1rnm6i1wc+JyL/NR7Lg/ pAYpdKqXHtLmkykRJPaTK9hjvU9+j0IWADJGJLxfXImMtcvzgTypZpRd6 U=; X-IronPort-AV: E=Sophos;i="5.56,342,1539648000"; d="scan'208";a="276187120" Received: from alln-core-7.cisco.com ([173.36.13.140]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 16:40:14 +0000 Received: from HYONKIM-7R0DR.cisco.com ([10.24.93.59]) by alln-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id wBBGeD9p013950 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 11 Dec 2018 16:40:14 GMT Date: Wed, 12 Dec 2018 01:40:12 +0900 From: Hyong Youb Kim To: "Varghese, Vipin" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , John Daley Message-ID: <20181211164012.GA25076@HYONKIM-7R0DR.cisco.com> References: <20181210182857.13043-1-hyonkim@cisco.com> <20181210182857.13043-5-hyonkim@cisco.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D98F9@BGSMSX101.gar.corp.intel.com> <20181211160832.GA24424@HYONKIM-7R0DR.cisco.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9C52@BGSMSX101.gar.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D9C52@BGSMSX101.gar.corp.intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Outbound-SMTP-Client: 10.24.93.59, [10.24.93.59] X-Outbound-Node: alln-core-7.cisco.com Subject: Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 16:40:16 -0000 On Tue, Dec 11, 2018 at 04:31:50PM +0000, Varghese, Vipin wrote: > Hi Hyong, > > snipped > > > Hi Hyong, > > > > > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been > > updated too?'(Section 16 under Network Interface Controller). > > > a. If yes is it ok to link the patchwork in comment section? > > > b. If no, will you be updating the documentation? > > > > > > > Vipin, > > > > I am not planning to update the enic guide, as these changes (fw version string, > > multicast filtering) do not need additional explanations. Did you have > > something else in mind? > > Thanks for sharing the information. > > In my humble opinion > > In documentation section '16.13. Supported features' states 'Unicast, multicast and broadcast transmission and reception'. So multicast 'filtering' to be added as supported feature or not is upto the individual for the PMD. But as you shared the information ' I am not planning to update the enic guide' I will leave this open to others for comment. I see what you mean now. Sure, I will send another patch to update that section later. As is, it is really a duplicate of doc/guides/nics/features. Not sure if we want to keep maintaining two copies of the same information. > > Question: Will there update for test cases for mac filtering been added? Reason the patch set is not covering test case addition. > We have an internal DTS based test case for multicast filtering. Do we need to mention test cases in commit logs now? I am a bit confused where this question is coming from.. -Hyong