Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported mask

[Ye Xiaolong <xiaolong.ye@intel.com>]

On 12/11, Ferruh Yigit wrote:
>On 12/11/2018 5:25 PM, Didier Pallard wrote:
>> This reverts
>> commit 09a62d75691f ("net/i40e: fix offload not supported mask")
>> 
>> Contrary to what is said in above patch commit log,
>> I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part
>> of PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK.
>> Above patch erroneously includes all PKT_RX_OFFLOAD_ bits in the
>> I40E_TX_OFFLOAD_NOTSUP_MASK, this is not what is expected.
>
>Argh, yes it does set Rx offload bits, +1 to revert.
>cc'ed author and maintainers of the PMD.
>

Thanks for catching it and sorry for my unthoughtful patch.

Thanks,
Xiaolong

>> Restore the initial xor that gives the expected result.
>> 
>> Fixes: 09a62d75691f ("net/i40e: fix offload not supported mask")
>> Cc: stable@dpdk.org
>> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
>> ---
>>  drivers/net/i40e/i40e_rxtx.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>> index e1152ff0ea58..ab74a488f88b 100644
>> --- a/drivers/net/i40e/i40e_rxtx.c
>> +++ b/drivers/net/i40e/i40e_rxtx.c
>> @@ -69,7 +69,7 @@
>>  		I40E_TX_IEEE1588_TMST)
>>  
>>  #define I40E_TX_OFFLOAD_NOTSUP_MASK \
>> -		~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK)
>> +		(PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
>>  
>>  static inline void
>>  i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp)
>> 
>