DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free
@ 2018-12-12 11:11 Yongseok Koh
  2018-12-20  6:55 ` Shahaf Shuler
  0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-12-12 11:11 UTC (permalink / raw)
  To: shahafs; +Cc: dev, stable

When MPRQ mempool is freed, the pointer stored in priv structure must be
reset to null. Otherwise, the mempool can be freed again if the port is
restarted.

Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
Cc: stable@dpdk.org

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 183da0e282..34c8338723 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1179,6 +1179,7 @@ mlx5_mprq_free_mp(struct rte_eth_dev *dev)
 			continue;
 		rxq->mprq_mp = NULL;
 	}
+	priv->mprq_mp = NULL;
 	return 0;
 }
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free
  2018-12-12 11:11 [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free Yongseok Koh
@ 2018-12-20  6:55 ` Shahaf Shuler
  0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-12-20  6:55 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev, stable

Wednesday, December 12, 2018 1:12 PM, Yongseok Koh:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free
> 
> When MPRQ mempool is freed, the pointer stored in priv structure must be
> reset to null. Otherwise, the mempool can be freed again if the port is
> restarted.
> 
> Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> ---
>  drivers/net/mlx5/mlx5_rxq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
> 183da0e282..34c8338723 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1179,6 +1179,7 @@ mlx5_mprq_free_mp(struct rte_eth_dev *dev)
>  			continue;
>  		rxq->mprq_mp = NULL;
>  	}
> +	priv->mprq_mp = NULL;
>  	return 0;
>  }
> 
> --
> 2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-20  6:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 11:11 [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free Yongseok Koh
2018-12-20  6:55 ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).