From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7DBC45F25 for ; Thu, 13 Dec 2018 23:35:14 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C3842309178B; Thu, 13 Dec 2018 22:35:13 +0000 (UTC) Received: from localhost (unknown [10.36.118.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39DF119008; Thu, 13 Dec 2018 22:35:10 +0000 (UTC) Date: Thu, 13 Dec 2018 23:35:08 +0100 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, Gavin.Hu@arm.com Message-ID: <20181213223508.t4z7m53t7q6mmh65@jenstp.localdomain> References: <20181213123453.15035-1-jfreimann@redhat.com> <20181213123453.15035-10-jfreimann@redhat.com> <7c5564bb-1a8b-73d6-54cb-a2069b97b615@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7c5564bb-1a8b-73d6-54cb-a2069b97b615@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 13 Dec 2018 22:35:13 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 22:35:14 -0000 On Thu, Dec 13, 2018 at 05:42:02PM +0100, Maxime Coquelin wrote: >It seems check-git-log.sh returns an error for this one. > >On 12/13/18 1:34 PM, Jens Freimann wrote: >>Until we have support for ctrl virtqueues let's disable it and >>exit if specified as a parameter. >> >>Signed-off-by: Jens Freimann >>--- >> drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >>diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>index 697ba4ae8..f9b83c423 100644 >>--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >>+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>@@ -467,10 +467,14 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, >> if (!in_order) >> dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER); >>- if (packed_vq) >>+ if (packed_vq) { >>+ if (cq) >>+ rte_exit(EXIT_FAILURE, >>+ "control vq not supported with packed virtqueues\n"); > >Sorry if I wasn't clear, but you should return -1 and not exit the >application using the DPDK lib. Ha, I did this first, but then I thought, no that doesn't seem useful because the notice you get is easy to miss between all the other output and then you run something that will not really work as expected :) But okay, I can change it to return -1. regards, Jens