From: Jeff Shaw <jeffrey.b.shaw@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jeff Shaw <jeffrey.b.shaw@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: remove variable length array
Date: Fri, 14 Dec 2018 10:59:28 -0800 [thread overview]
Message-ID: <20181214185928.GA9964@ae13-28.jf.intel.com> (raw)
In-Reply-To: <20181214103603.59336e0e@xeon-e3>
On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote:
> On Fri, 14 Dec 2018 08:38:27 -0800
> Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> > Compilers that do not support the C11 standard, or do not implement
> > gcc extensions, may not support variable length arrays.
> >
> > The code prior to this commit produced the following warning when
> > compiled with "-Wvla -std=c90".
> >
> > warning: ISO C90 forbids variable length array ‘array’ [-Wvla]
> >
> > This commit removes the variable length array from the PMD debug
> > trace function by allocating memory dynamically on the stack using
> > alloca().
> >
> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> > ---
> > lib/librte_eal/common/include/rte_dev.h | 19 +++++++++----------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> > index a9724dc91..af772872b 100644
> > --- a/lib/librte_eal/common/include/rte_dev.h
> > +++ b/lib/librte_eal/common/include/rte_dev.h
> > @@ -47,22 +47,21 @@ __attribute__((format(printf, 2, 0)))
> > static inline void
> > rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
> > {
> > + char *buffer;
> > + int buf_len;
> > va_list ap;
> >
> > va_start(ap, fmt);
> > + buf_len = vsnprintf(NULL, 0, fmt, ap) + 1;
> > + va_end(ap);
> >
> > - {
> > - char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];
> > + buffer = (char *)alloca(buf_len);
>
> alloca is void * so cast is not necessary.
I get a compiler warning on Windows, hence the cast. I suppose we could
disable the warning.
>
> You might be able to skip the buffering step entirely by using rte_log
> a little more creatively, see how other logging works.
Probably right... this eventuall needs to be done in ~100 other places,
most of which aren't used with rte_log(), so it seemed fitting.
>
> But to go further since rte_pmd_debug_trace is not used anywhere in
> current code base in DPDK, it should just be removed.
Much better solution :)
next prev parent reply other threads:[~2018-12-14 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:38 Jeff Shaw
2018-12-14 18:36 ` Stephen Hemminger
2018-12-14 18:59 ` Jeff Shaw [this message]
2018-12-14 19:17 ` Jeff Shaw
2018-12-14 18:36 ` Mattias Rönnblom
2018-12-14 19:07 ` Jeff Shaw
2018-12-14 20:28 ` Mattias Rönnblom
2018-12-14 20:50 ` [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE Stephen Hemminger
2018-12-14 21:20 ` Jeff Shaw
2018-12-14 21:57 ` Stephen Hemminger
2018-12-21 16:17 ` Ferruh Yigit
2018-12-21 18:11 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-21 18:18 ` [dpdk-dev] [PATCH v3] " Jeff Shaw
2018-12-22 0:37 ` Ferruh Yigit
2018-12-19 21:45 ` [dpdk-dev] [PATCH] eal: remove variable length array Thomas Monjalon
2018-12-20 10:53 ` Mattias Rönnblom
2018-12-20 11:03 ` Thomas Monjalon
2018-12-14 20:40 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-15 14:26 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214185928.GA9964@ae13-28.jf.intel.com \
--to=jeffrey.b.shaw@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).