* [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg
@ 2018-12-16 23:01 Keith Wiles
2018-12-17 9:25 ` Gaëtan Rivet
0 siblings, 1 reply; 3+ messages in thread
From: Keith Wiles @ 2018-12-16 23:01 UTC (permalink / raw)
To: dev
Add a missing newline to a RTE_LOG message.
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
lib/librte_eal/common/rte_option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
index 02d59a869..7605190c3 100644
--- a/lib/librte_eal/common/rte_option.c
+++ b/lib/librte_eal/common/rte_option.c
@@ -36,7 +36,7 @@ rte_option_register(struct rte_option *opt)
{
TAILQ_FOREACH(option, &rte_option_list, next) {
if (strcmp(opt->opt_str, option->opt_str) == 0)
- RTE_LOG(INFO, EAL, "Option %s has already been registered.",
+ RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
opt->opt_str);
return;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg
2018-12-16 23:01 [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg Keith Wiles
@ 2018-12-17 9:25 ` Gaëtan Rivet
2018-12-19 22:53 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Gaëtan Rivet @ 2018-12-17 9:25 UTC (permalink / raw)
To: Keith Wiles; +Cc: dev
Hi Keith,
On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote:
> Add a missing newline to a RTE_LOG message.
>
I think it might interest stable@dpdk.org, and you might as well include
a fixline reference.
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> lib/librte_eal/common/rte_option.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
> index 02d59a869..7605190c3 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -36,7 +36,7 @@ rte_option_register(struct rte_option *opt)
> {
> TAILQ_FOREACH(option, &rte_option_list, next) {
> if (strcmp(opt->opt_str, option->opt_str) == 0)
> - RTE_LOG(INFO, EAL, "Option %s has already been registered.",
> + RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
> opt->opt_str);
> return;
> }
> --
> 2.17.1
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg
2018-12-17 9:25 ` Gaëtan Rivet
@ 2018-12-19 22:53 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-12-19 22:53 UTC (permalink / raw)
To: Keith Wiles; +Cc: dev, Gaëtan Rivet
17/12/2018 10:25, Gaëtan Rivet:
> Hi Keith,
>
> On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote:
> > Add a missing newline to a RTE_LOG message.
> >
>
> I think it might interest stable@dpdk.org, and you might as well include
> a fixline reference.
Fixes: 2395332798d0 ("eal: add option register infrastructure")
Cc: stable@dpdk.org
> > Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-16 23:01 [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg Keith Wiles
2018-12-17 9:25 ` Gaëtan Rivet
2018-12-19 22:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).