From: Jens Freimann <jfreimann@redhat.com>
To: dev@dpdk.org
Cc: tiwei.bie@intel.com, maxime.coquelin@redhat.com, Gavin.Hu@arm.com
Subject: [dpdk-dev] [PATCH v14 09/10] net/virtio-user: fail if cq used with packed vq
Date: Mon, 17 Dec 2018 22:31:38 +0100 [thread overview]
Message-ID: <20181217213139.19299-10-jfreimann@redhat.com> (raw)
In-Reply-To: <20181217213139.19299-1-jfreimann@redhat.com>
Until we have support for control virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 697ba4ae8..4e331fc6a 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
if (!in_order)
dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);
- if (packed_vq)
+ if (packed_vq) {
+ if (cq) {
+ PMD_INIT_LOG(ERR, "control vq not supported yet with "
+ "packed virtqueues\n");
+ return -1;
+ }
dev->device_features |= (1ull << VIRTIO_F_RING_PACKED);
- else
+ } else {
dev->device_features &= ~(1ull << VIRTIO_F_RING_PACKED);
+ }
if (dev->mac_specified) {
dev->device_features |= (1ull << VIRTIO_NET_F_MAC);
--
2.17.2
next prev parent reply other threads:[~2018-12-17 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 21:31 [dpdk-dev] [PATCH v14 00/10] implement packed virtqueues Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 01/10] net/virtio: add packed virtqueue defines Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 02/10] net/virtio: add packed virtqueue helpers Jens Freimann
2018-12-18 10:57 ` Maxime Coquelin
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 03/10] net/virtio: vring init for packed queues Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 04/10] net/virtio: dump packed virtqueue data Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 05/10] net/virtio: implement transmit path for packed queues Jens Freimann
2018-12-18 15:52 ` Ferruh Yigit
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 06/10] net/virtio: implement receive " Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 07/10] net/virtio: add virtio send command packed queue support Jens Freimann
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 08/10] net/virtio-user: add option to use packed queues Jens Freimann
2018-12-17 21:31 ` Jens Freimann [this message]
2018-12-18 10:58 ` [dpdk-dev] [PATCH v14 09/10] net/virtio-user: fail if cq used with packed vq Maxime Coquelin
2018-12-17 21:31 ` [dpdk-dev] [PATCH v14 10/10] net/virtio: enable packed virtqueues by default Jens Freimann
2018-12-18 14:02 ` [dpdk-dev] [PATCH v14 00/10] implement packed virtqueues Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217213139.19299-10-jfreimann@redhat.com \
--to=jfreimann@redhat.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).