From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, i.maximets@samsung.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, jasowang@redhat.com, mst@redhat.com
Cc: stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v2 4/4] vhost: remove useless prefetch for packed ring descriptor
Date: Wed, 19 Dec 2018 09:21:13 +0100 [thread overview]
Message-ID: <20181219082113.24455-5-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20181219082113.24455-1-maxime.coquelin@redhat.com>
This prefetch does not show any performance improvement.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/virtio_net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index a9be633de..4d201a3fd 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -1437,8 +1437,6 @@ virtio_dev_tx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,
{
uint16_t i;
- rte_prefetch0(&vq->desc_packed[vq->last_avail_idx]);
-
if (unlikely(dev->dequeue_zero_copy)) {
struct zcopy_mbuf *zmbuf, *next;
--
2.17.2
next prev parent reply other threads:[~2018-12-19 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 8:21 [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching Maxime Coquelin
2018-12-19 8:21 ` [dpdk-dev] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering Maxime Coquelin
2018-12-19 15:47 ` Michael S. Tsirkin
2018-12-19 15:50 ` Maxime Coquelin
2018-12-19 8:21 ` [dpdk-dev] [PATCH v2 2/4] vhost: enforce desc flags and content " Maxime Coquelin
2018-12-19 8:21 ` [dpdk-dev] [PATCH v2 3/4] vhost: prefetch descriptor after the read barrier Maxime Coquelin
2018-12-19 8:21 ` Maxime Coquelin [this message]
2018-12-19 15:49 ` [dpdk-dev] [PATCH v2 4/4] vhost: remove useless prefetch for packed ring descriptor Michael S. Tsirkin
2018-12-19 15:50 ` [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching Michael S. Tsirkin
2018-12-19 16:28 ` Ilya Maximets
2018-12-20 4:39 ` Tiwei Bie
2018-12-20 18:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219082113.24455-5-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).