From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6976F1B53A; Wed, 19 Dec 2018 10:17:39 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 01:17:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="120037915" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga001.jf.intel.com with ESMTP; 19 Dec 2018 01:17:37 -0800 Date: Wed, 19 Dec 2018 17:15:33 +0800 From: Tiwei Bie To: Hideyuki Yamashita Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, stable@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp Message-ID: <20181219091533.GB32582@dpdk-tbie.sh.intel.com> References: <201812190440.wBJ4cabt027283@ccmail04.silk.ntt-tx.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201812190440.wBJ4cabt027283@ccmail04.silk.ntt-tx.co.jp> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/vhost: fix double free of MAC addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 09:17:40 -0000 On Wed, Dec 19, 2018 at 01:37:18PM +0900, Hideyuki Yamashita wrote: > The common data freeing has been moved to rte_eth_dev_release_port(), > so freeing mac_addrs like this in eth_dev_close() is unnecessary and > will cause double free. > > Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") > Cc: stable@dpdk.org > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Yasufumi Ogawa > --- > drivers/net/vhost/rte_eth_vhost.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index 42bdfcbd5..b2cda0483 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -1000,7 +1000,6 @@ eth_dev_close(struct rte_eth_dev *dev) > for (i = 0; i < dev->data->nb_tx_queues; i++) > rte_free(dev->data->tx_queues[i]); > > - rte_free(dev->data->mac_addrs); > free(internal->dev_name); > free(internal->iface_name); > rte_free(internal); > -- > 2.18.0 Reviewed-by: Tiwei Bie