From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 643C71B940; Wed, 19 Dec 2018 16:50:47 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BCCC27F3FA; Wed, 19 Dec 2018 15:50:46 +0000 (UTC) Received: from redhat.com (ovpn-120-67.rdu2.redhat.com [10.10.120.67]) by smtp.corp.redhat.com (Postfix) with SMTP id CFA451802C; Wed, 19 Dec 2018 15:50:43 +0000 (UTC) Date: Wed, 19 Dec 2018 10:50:42 -0500 From: "Michael S. Tsirkin" To: Maxime Coquelin Cc: dev@dpdk.org, i.maximets@samsung.com, tiwei.bie@intel.com, zhihong.wang@intel.com, jasowang@redhat.com, stable@dpdk.org Message-ID: <20181219104947-mutt-send-email-mst@kernel.org> References: <20181219082113.24455-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181219082113.24455-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 19 Dec 2018 15:50:46 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 15:50:47 -0000 On Wed, Dec 19, 2018 at 09:21:09AM +0100, Maxime Coquelin wrote: > This series adds missing read barriers after reading avail index > for split ring and desc flags for packed ring. > > Also, it turns out that some descriptors prefetching are either > badly placed, or useless, last part of the series fixes that. > > With the series applied, I get between 0 and 4% gain depending > on the benchmark (testpmd txonly/rxonly/io). > > Thanks to Jason for reporting the missing read barriers. Acked-by: Michael S. Tsirkin But I wonder what effect this has on ARM where RMB isn't a NOP. Ilya do you happen to have any data? > Changes since v1: > ================= > - Drop volatile removal patch (Ilya) > - Improve commit messages for RMB patches (Ilya) > > Maxime Coquelin (4): > vhost: enforce avail index and desc read ordering > vhost: enforce desc flags and content read ordering > vhost: prefetch descriptor after the read barrier > vhost: remove useless prefetch for packed ring descriptor > > lib/librte_vhost/virtio_net.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) > > -- > 2.17.2