From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3C248316B for ; Wed, 19 Dec 2018 12:00:17 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 03:00:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="119637830" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.32]) by FMSMGA003.fm.intel.com with SMTP; 19 Dec 2018 03:00:13 -0800 Received: by (sSMTP sendmail emulation); Wed, 19 Dec 2018 11:00:12 +0000 Date: Wed, 19 Dec 2018 11:00:12 +0000 From: Bruce Richardson To: "Ananyev, Konstantin" Cc: Mattias =?iso-8859-1?Q?R=F6nnblom?= , Honnappa Nagarahalli , "dev@dpdk.org" , nd , "Gavin Hu (Arm Technology China)" Message-ID: <20181219110011.GA16052@bricha3-MOBL.ger.corp.intel.com> References: <1542130061-3702-1-git-send-email-konstantin.ananyev@intel.com> <1542130061-3702-2-git-send-email-konstantin.ananyev@intel.com> <2601191342CEEE43887BDE71AB977258010D8BC760@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8BC760@IRSMSX106.ger.corp.intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 11:00:17 -0000 On Wed, Dec 19, 2018 at 10:56:09AM +0000, Ananyev, Konstantin wrote: > > > > -----Original Message----- > > From: Mattias Rönnblom [mailto:hofors@lysator.liu.se] > > Sent: Wednesday, December 19, 2018 10:28 AM > > To: Honnappa Nagarahalli ; Ananyev, Konstantin ; dev@dpdk.org > > Cc: nd ; Gavin Hu (Arm Technology China) > > Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking > > > > On 2018-12-19 07:37, Honnappa Nagarahalli wrote: > > >> diff --git a/lib/librte_eal/rte_eal_version.map > > >> b/lib/librte_eal/rte_eal_version.map > > >> index 3fe78260d..8b1593dd8 100644 > > >> --- a/lib/librte_eal/rte_eal_version.map > > >> +++ b/lib/librte_eal/rte_eal_version.map > > >> @@ -355,6 +355,8 @@ EXPERIMENTAL { > > >> rte_mp_request_async; > > >> rte_mp_sendmsg; > > >> rte_option_register; > > >> + rte_rwlock_read_trylock; > > >> + rte_rwlock_write_trylock; > > > I do not see the other RW lock APIs in this file. > > > > > > > They, just like those added, are static inline functions, will not > > result in any symbols in any shared objects and thus shouldn't be in any > > version.map file. > > So, are you guys trying to say that there is no need to put these 'trylock' > functions into 'experimental' section? > Konstantin > Anything static inline doesn't have a mapfile entry, so there is no issue there. However, the APIs themselves, since they are new should probably have the __rte_experimental attribute marked on them in the code. /Bruce