From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id 2D5B91B94E
 for <dev@dpdk.org>; Wed, 19 Dec 2018 13:43:51 +0100 (CET)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBJChkEH023256;
 Wed, 19 Dec 2018 04:43:47 -0800
Date: Wed, 19 Dec 2018 18:12:03 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Satish Rangarajan <satishr@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
Message-ID: <20181219124202.GC11932@chelsio.com>
References: <1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com>
 <1544713333-32239-2-git-send-email-rahul.lakkireddy@chelsio.com>
 <80fd308b-07a4-056b-60be-5fcd9143d6f4@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <80fd308b-07a4-056b-60be-5fcd9143d6f4@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for
 including header files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 12:43:52 -0000

On Tuesday, December 12/18/18, 2018 at 23:53:38 +0530, Ferruh Yigit wrote:
> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> > Explicitly state header file location using relative paths.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > ---
> >  drivers/net/cxgbe/Makefile         | 2 --
> >  drivers/net/cxgbe/base/adapter.h   | 4 ++--
> >  drivers/net/cxgbe/base/common.h    | 2 +-
> >  drivers/net/cxgbe/clip_tbl.c       | 2 +-
> >  drivers/net/cxgbe/cxgbe.h          | 4 ++--
> >  drivers/net/cxgbe/cxgbe_ethdev.c   | 2 +-
> >  drivers/net/cxgbe/cxgbe_filter.c   | 7 ++++---
> >  drivers/net/cxgbe/cxgbe_filter.h   | 2 +-
> >  drivers/net/cxgbe/cxgbe_flow.c     | 2 +-
> >  drivers/net/cxgbe/cxgbe_main.c     | 6 +++---
> >  drivers/net/cxgbe/cxgbevf_ethdev.c | 2 +-
> >  drivers/net/cxgbe/cxgbevf_main.c   | 6 +++---
> >  drivers/net/cxgbe/l2t.c            | 3 ++-
> >  drivers/net/cxgbe/l2t.h            | 2 +-
> >  drivers/net/cxgbe/mps_tcam.h       | 2 +-
> >  drivers/net/cxgbe/sge.c            | 6 +++---
> >  16 files changed, 27 insertions(+), 27 deletions(-)
> > 
> > diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
> > index 68466f13e..d809f4720 100644
> > --- a/drivers/net/cxgbe/Makefile
> > +++ b/drivers/net/cxgbe/Makefile
> > @@ -9,8 +9,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
> >  #
> >  LIB = librte_pmd_cxgbe.a
> >  
> > -CFLAGS += -I$(SRCDIR)/base/
> > -CFLAGS += -I$(SRCDIR)
> >  CFLAGS += -O3
> >  CFLAGS += $(WERROR_FLAGS)
> 
> Hi Rahul,
> 
> What issue do you observe if you don't use relative paths?

The Intel C++ compiler [1] is not able to locate the header files without
relative path in Windows. We get the following error for these header
files.

# base\common.h(9): error : cannot open source file "cxgbe_compat.h"
    #include "cxgbe_compat.h"
                             ^

We could reproduce the same error by removing the above two lines for
Linux. To keep it consistent across both OS, I'm using relative paths
for both.

[1] https://software.intel.com/en-us/parallel-studio-xe

Thanks,
Rahul