From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id DA7351B936
 for <dev@dpdk.org>; Thu, 20 Dec 2018 04:55:50 +0100 (CET)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBK3tksf027818;
 Wed, 19 Dec 2018 19:55:47 -0800
Date: Thu, 20 Dec 2018 09:24:07 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Satish Rangarajan <satishr@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
Message-ID: <20181220035406.GA13374@chelsio.com>
References: <cover.1545236474.git.rahul.lakkireddy@chelsio.com>
 <fb2b34d2-e6ee-5426-0e53-68d96f0fa286@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb2b34d2-e6ee-5426-0e53-68d96f0fa286@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft
 Windows OS support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 03:55:51 -0000

On Thursday, December 12/20/18, 2018 at 03:09:44 +0530, Ferruh Yigit wrote:
> On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote:
> > This series of patches fix compilation warning and errors seen while
> > building CXGBE PMD in preparation for Microsoft Windows OS support.
> > 
> > Patch 1 uses relative paths for including header files.
> > Patch 2 fixes macros related to rte_log().
> > Patch 3 only redefines symbols when they are not available.
> > Patch 4 fixes other misc build issues.
> > 
> > Patches are generated against dpdk-next-net tree.
> > 
> > Build Environment:
> > 1. Target OS: Microsoft Windows Server 2016
> > 2. Compiler: Intel C++ Compiler v19 from Intel Parallel Studio XE 2019 [1]
> > 3. Development Tools:
> >    3.1 Microsoft Visual Studio 2017 Professional
> >    3.2 Windows Software Development Kit (SDK) v10.0.17763
> >    3.3 Windows Driver Kit (WDK) v10.0.17763
> > 
> > [1] https://software.intel.com/en-us/parallel-studio-xe
> > 
> > Thanks,
> > Rahul
> > 
> > ---
> > v2:
> > - Add more info in commit message regarding Windows build.
> > 
> > Rahul Lakkireddy (4):
> >   net/cxgbe: use relative paths for including header files
> >   net/cxgbe: fix macros related to logs for Windows
> >   net/cxgbe: only define symbols when not available
> >   net/cxgbe: fix other misc build issues for Windows
> 
> Series applied to dpdk-next-net/master, thanks.
> 
> Beware none of the patches has fixes lines, so they won't be backported by default.
> If this wasn't the intention please provide fixes lines and I can update in tree.

Thanks Ferruh. I intentionally left out the fixes lines. Don't backport
these patches.

Thanks,
Rahul