DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching
@ 2018-12-19  8:21 Maxime Coquelin
  2018-12-19  8:21 ` [dpdk-dev] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering Maxime Coquelin
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Maxime Coquelin @ 2018-12-19  8:21 UTC (permalink / raw)
  To: dev, i.maximets, tiwei.bie, zhihong.wang, jasowang, mst
  Cc: stable, Maxime Coquelin

This series adds missing read barriers after reading avail index
for split ring and desc flags for packed ring.

Also, it turns out that some descriptors prefetching are either
badly placed, or useless, last part of the series fixes that.

With the series applied, I get between 0 and 4% gain depending
on the benchmark (testpmd txonly/rxonly/io).

Thanks to Jason for reporting the missing read barriers.

Changes since v1:
=================
- Drop volatile removal patch (Ilya)
- Improve commit messages for RMB patches (Ilya)

Maxime Coquelin (4):
  vhost: enforce avail index and desc read ordering
  vhost: enforce desc flags and content read ordering
  vhost: prefetch descriptor after the read barrier
  vhost: remove useless prefetch for packed ring descriptor

 lib/librte_vhost/virtio_net.c | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)

-- 
2.17.2

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-12-20 18:19 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19  8:21 [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching Maxime Coquelin
2018-12-19  8:21 ` [dpdk-dev] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering Maxime Coquelin
2018-12-19 15:47   ` Michael S. Tsirkin
2018-12-19 15:50     ` Maxime Coquelin
2018-12-19  8:21 ` [dpdk-dev] [PATCH v2 2/4] vhost: enforce desc flags and content " Maxime Coquelin
2018-12-19  8:21 ` [dpdk-dev] [PATCH v2 3/4] vhost: prefetch descriptor after the read barrier Maxime Coquelin
2018-12-19  8:21 ` [dpdk-dev] [PATCH v2 4/4] vhost: remove useless prefetch for packed ring descriptor Maxime Coquelin
2018-12-19 15:49   ` Michael S. Tsirkin
2018-12-19 15:50 ` [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching Michael S. Tsirkin
2018-12-19 16:28   ` Ilya Maximets
2018-12-20  4:39 ` Tiwei Bie
2018-12-20 18:19 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).