From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A4A1B1BA8F for ; Thu, 20 Dec 2018 11:54:59 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 02:54:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,376,1539673200"; d="scan'208";a="131538995" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2018 02:54:57 -0800 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id wBKAsuOP022687; Thu, 20 Dec 2018 10:54:56 GMT Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id wBKAsuo3015695; Thu, 20 Dec 2018 10:54:56 GMT Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id wBKAsrwC015687; Thu, 20 Dec 2018 10:54:53 GMT Date: Thu, 20 Dec 2018 10:54:53 +0000 From: "Liang, Ma" To: Thomas Monjalon Cc: "Burakov, Anatoly" , bluca@debian.org, "Hunt, David" , dev@dpdk.org, qian.q.xu@intel.com, ferruh.yigit@intel.com Message-ID: <20181220105453.GC26517@sivswdev09.ir.intel.com> References: <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com> <9037763.qK0Rf51nFT@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9037763.qK0Rf51nFT@xps> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 10:55:00 -0000 On 20 Dec 11:10, Thomas Monjalon wrote: > 20/12/2018 10:33, Burakov, Anatoly: > > On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote: > > > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote: > > >> 19/12/2018 10:09, Hunt, David: > > >>> On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > > >>>> 14/12/2018 14:11, Liang Ma: > > >>>>> Previously, in order to use the power library, it was necessary > > >>>>> for the user to disable the intel_pstate driver by adding > > >>>>> “intel_pstate=disable” to the kernel command line for the system, > > >>>>> which causes the acpi_cpufreq driver to be loaded in its place. > > >>>>> > > >>>>> This patch adds the ability for the power library use the intel-pstate > > >>>>> driver. > > >>>>> > > >>>>> It adds a new suite of functions behind the current power library API, > > >>>>> and will seamlessly set up the user facing API function pointers to > > >>>>> the relevant functions depending on whether the system is running with > > >>>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest, > > >>>>> using kvm. The library API and ABI is unchanged. > > >>>>> > > >>>>> Signed-off-by: Liang Ma > > >>>>> > > >>>>> Reviewed-by: Anatoly Burakov > > >>>>> --- > > >>>> Please write a changelog when sending a new version. > > >>>> > > >>>> Dave, any comment on this patch? > > >>> > > >>> > > >>> Looks good to me. > > >>> > > >>> Acked-by: David Hunt > > >>> > > >>> > > >>>>> --- /dev/null > > >>>>> +++ b/lib/librte_power/power_pstate_cpufreq.c > > >>>>> @@ -0,0 +1,770 @@ > > >>>>> +/* SPDX-License-Identifier: BSD-3-Clause > > >>>>> + * Copyright(c) 2018-2018 Intel Corporation > > >>>> Something wrong here :) > > >>> > > >>> Yes, should simply be "Copyright(c) 2018 Intel Corporation" > > >> > > >> > > >> There is also a compilation error with meson: > > >> > > >> lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > > >> rte_timer.h: No such file or directory > > > > > > That's an EAL header, and this file was not modified or referenced in > > > this commit. This sounds like a pre-existing problem (with meson > > > build-system?), not related to the patchset. > > > > > > Is this library not built by default by our patch compilation CI? > > > > > > > Disregard that, the patch has a bug in meson build file. > > Yes, I did a mistake when I edit the meson build file. I will push the fix very soon. we are testing the fix now. > > Still, why doesn't our CI build meson? > > I think we should build a new CI for compilation testing. > Luca proposed to use OBS. > Luca, can we work on it? > >