From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id A67C51BDC2 for ; Fri, 21 Dec 2018 14:17:08 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id u4so5229937wrp.3 for ; Fri, 21 Dec 2018 05:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=RSwzdKa5awquezid/vG6gqphltnGH4A+e+xk9LEw1gs=; b=1Wl20i72Ky1dxMdIGn8eaqXRJQGjWs0kKfPrrgjNVoC2/9fE8VAZKRhxNheuq6WR1N uaOgSW9NVH3hWr6SI7x3sYBgIzgiqKNiotA9T4s6tJ41DDdIZ8XFWaSk5ib+1nDrZdSV teEXp7ek+XegioqWEd+HBz2+Rbp34gRO7GO+xAqP+437ysGujcDL2NN8reU3w4ZS+tI1 1MsYnFXfk9wVwHnREIUNDQl9dTT6+xvJZ3n34OIJGFpw/oixM8smKydH+3ZQDtb54NPU k8xpqtwp4fDUkJB4oiomZRQhTUdxWvoYNcIROnKZwIsKEVlA8o2jFRqQeeafmIBeRyBB Fchg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=RSwzdKa5awquezid/vG6gqphltnGH4A+e+xk9LEw1gs=; b=ki44s6PBGAAdZ52hNddqNRBym+VjRFqZyL/aRQBRd4uSMNNMLNuGK2bXCtaDFf3sGq jqMmGQiSDGNkNw3LEk8cp8DS3t/Jq9Sh2nsmG67rootuifqgsv3T6d0J2mNmWb2Y8N01 BbyjPDFOYOajGGAYRvIyTb5I9PcilqBRhKRfg/24/jd5TmBkig0mUDNzCWQlfho0C3aE nhSWGIjADmUbmUT6AFoEhhpW8ovnJqHuAsN9BqNvYS7DPHuuCkz1NxF6BMzJGz3o35c6 9dDEZbpt5b6zzWChm2/SWYnAIRupeBuPbWgij+k7QF7np/0kVu+GFEL3knXkRl1bUF2l Q3WA== X-Gm-Message-State: AJcUukdyd5S1VrB8MC1MobxrWRysML7wYyuI8PZ+jF71orIEEOGtjx24 AmIRVyMl7vORuqy9R0jN/Z5QaA== X-Google-Smtp-Source: ALg8bN7ELiYAq2Ko4MkuDS7yP+rUtz0BqgKlqqmOPaL5yltJAnVeuI1NrOedChac+3yZAcGyKD2H1Q== X-Received: by 2002:adf:9d08:: with SMTP id k8mr2743629wre.203.1545398228084; Fri, 21 Dec 2018 05:17:08 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i186sm13940705wmd.19.2018.12.21.05.17.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 05:17:07 -0800 (PST) Date: Fri, 21 Dec 2018 14:16:46 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Andrew Rybchenko Cc: Ferruh Yigit , dev@dpdk.org, Ivan Malov Message-ID: <20181221131646.2yqimi7rejnebrvd@bidouze.vm.6wind.com> References: <1539344187-21481-1-git-send-email-arybchenko@solarflare.com> <585c9670-07b6-abfa-027d-e4d07febb7d4@intel.com> <969cb7e3-6e1a-f5ac-ed1b-e4334f928b17@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <969cb7e3-6e1a-f5ac-ed1b-e4334f928b17@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] net/failsafe: add default Tx mbuf fast free capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 13:17:08 -0000 Hi Ferruh, Andrew, On Fri, Dec 21, 2018 at 03:52:07PM +0300, Andrew Rybchenko wrote: > Hi Ferruh, > > On 12/21/18 3:43 PM, Ferruh Yigit wrote: > > On 12/21/2018 12:28 PM, Andrew Rybchenko wrote: > > > On 12/21/18 3:12 PM, Ferruh Yigit wrote: > > > > On 10/12/2018 12:36 PM, Andrew Rybchenko wrote: > > > > > From: Ivan Malov > > > > > > > > > > This capability is reported when supported by the current emitting > > > > > sub-device. Failsafe PMD itself does not excercise fast free logic. > > > > I think overlay device capability reporting already discussed a few times, the > > > > question is if an overlay devices should claim a feature when it depends on > > > > underlay devices? > > > The capability may be reported by the failsafe since it is transparent from > > > fast free logic point of view. > > Why it is transparent? If one of the underlying device doesn't support/claim > > this feature, application can't use this feature with failsafe, isn't it? If a VF is forbidden by its PF from adding MAC addresses, the driver should still advertize support for "Unicast MAC filter" right? This is the same here. Fail-safe needs to forward configurations items to its sub-device for a feature to work. Sometimes, the hardware won't be sufficient. But the fail-safe itself still has the parts needed (even if it is only a flag to add to a feature list). It is necessary, at the fail-safe level, to be able to describe the current feature set. This is what the feature list is for. There are important caveats to consider however, which is inherent to using the fail-safe. It does not mean those features should be removed from the fail-safe feature list. > > tx_offload_capa in failsafe is a mask to apply on sub-device capabilities. > So, if the capability is not supported by any sub-device it will not be > reported. > As well if there is the capability bit in the mask, it will not be reported > regardless > sub-devices capabilities. The description for the patch above tries to > explain it - > it looks like not that successful. > > > > > Given that no ack/review given to the patch, I am updating it as rejected. > > > Is it a new policy? I thought that it was vice versa before. > > Hi Andrew, > > > > Yes policy is other-way around indeed, when there is no comment at all default > > behavior is accept, but please take above paragraph as my comment to the patch. > > Got it. > > > And I was thinking it is a little controversial and there is no support to have > > it, so lets don't get it. What do you think? > > I see you motivation. > > > > > > Signed-off-by: Ivan Malov > > > > > Signed-off-by: Andrew Rybchenko > > > > > --- > > > > > doc/guides/nics/features/failsafe.ini | 1 + > > > > > drivers/net/failsafe/failsafe_ops.c | 1 + > > > > > 2 files changed, 2 insertions(+) > > > > > > > > > > diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini > > > > > index e3c4c08f2..b6f3dcee6 100644 > > > > > --- a/doc/guides/nics/features/failsafe.ini > > > > > +++ b/doc/guides/nics/features/failsafe.ini > > > > > @@ -7,6 +7,7 @@ > > > > > Link status = Y > > > > > Link status event = Y > > > > > Rx interrupt = Y > > > > > +Fast mbuf free = Y > > > > > Queue start/stop = Y > > > > > Runtime Rx queue setup = Y > > > > > Runtime Tx queue setup = Y > > > > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > > > > > index 7f8bcd4c6..e3add404b 100644 > > > > > --- a/drivers/net/failsafe/failsafe_ops.c > > > > > +++ b/drivers/net/failsafe/failsafe_ops.c > > > > > @@ -78,6 +78,7 @@ static struct rte_eth_dev_info default_infos = { > > > > > DEV_RX_OFFLOAD_SECURITY, > > > > > .tx_offload_capa = > > > > > DEV_TX_OFFLOAD_MULTI_SEGS | > > > > > + DEV_TX_OFFLOAD_MBUF_FAST_FREE | > > > > > DEV_TX_OFFLOAD_IPV4_CKSUM | > > > > > DEV_TX_OFFLOAD_UDP_CKSUM | > > > > > DEV_TX_OFFLOAD_TCP_CKSUM | > > > > > > -- Gaëtan Rivet 6WIND