From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m12-17.163.com (m12-17.163.com [220.181.12.17]) by dpdk.org (Postfix) with ESMTP id DBA0C1B94E for ; Sat, 22 Dec 2018 13:40:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=h21fqycXXyfhxlnyuk 28F9QIJizPpiWlrpUTjkzRWVw=; b=aS7cWkhLZHfXkrtFlTyrAmTGvqJ1mu1xyo 2HjsabRLYSEeC60hgVR0PFwbSb4DNFegnJkqa/f83woHOJ7kvv88qTdPe35oGeKi 62zPBZg+7+P0Tlzr1Vo2wLKyOd7BH5vAujHKt4PfM6F9+/HHxztkDlgGmoinTFlD fpHq0uhTo= Received: from localhost (unknown [14.17.22.40]) by smtp13 (Coremail) with SMTP id EcCowADn34PMMB5cxqcNAQ--.14890S2; Sat, 22 Dec 2018 20:40:44 +0800 (CST) From: Haiyang Tan To: Wenzhuo Lu , Konstantin Ananyev Cc: dev@dpdk.org, Haiyang Tan Date: Sat, 22 Dec 2018 04:40:14 -0800 Message-Id: <20181222124014.95181-1-haiyangtan@tencent.com> X-Mailer: git-send-email 2.14.1 X-CM-TRANSID: EcCowADn34PMMB5cxqcNAQ--.14890S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7urWrJw1ftrWDWF1fXF1DZFb_yoW8WrWrpa 97Wr1jk3WDZF1UuFyxXanxXrnI9a18Ca47tFyIyw1rCw47Jry8GF4qkry0vr1xK3y7Xa17 WFyIqw4q9ay3WrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jz4E_UUUUU= X-Originating-IP: [14.17.22.40] Sender: thy295@163.com X-CM-SenderInfo: xwk1jmqv6rljoofrz/xtbBEgwlP1ZX-WZrTQAAs4 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix possible uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 12:40:48 -0000 The uninitialized field 'extra_flag' of hash parameter may enable certain feature silently. Typically, if bit0 of 'extra_flag' set, the hardware transactional memory support will be enabled unexpectedly. Signed-off-by: Haiyang Tan --- drivers/net/ixgbe/ixgbe_ethdev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 749311048..017d61178 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1426,14 +1426,14 @@ static int ixgbe_fdir_filter_init(struct rte_eth_dev *eth_dev) struct ixgbe_hw_fdir_info *fdir_info = IXGBE_DEV_PRIVATE_TO_FDIR_INFO(eth_dev->data->dev_private); char fdir_hash_name[RTE_HASH_NAMESIZE]; - struct rte_hash_parameters fdir_hash_params = { - .name = fdir_hash_name, - .entries = IXGBE_MAX_FDIR_FILTER_NUM, - .key_len = sizeof(union ixgbe_atr_input), - .hash_func = rte_hash_crc, - .hash_func_init_val = 0, - .socket_id = rte_socket_id(), - }; + struct rte_hash_parameters fdir_hash_params = { 0 }; + + fdir_hash_params.name = fdir_hash_name; + fdir_hash_params.entries = IXGBE_MAX_FDIR_FILTER_NUM; + fdir_hash_params.key_len = sizeof(union ixgbe_atr_input); + fdir_hash_params.hash_func = rte_hash_crc; + fdir_hash_params.hash_func_init_val = 0; + fdir_hash_params.socket_id = rte_socket_id(); TAILQ_INIT(&fdir_info->fdir_list); snprintf(fdir_hash_name, RTE_HASH_NAMESIZE, -- 2.14.1