From: Gavin Hu <gavin.hu@arm.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, jerinj@marvell.com, hemant.agrawal@nxp.com,
bruce.richardson@intel.com, chaozhu@linux.vnet.ibm.com,
Honnappa.Nagarahalli@arm.com, stephen@networkplumber.org,
david.marchand@redhat.com, nd@arm.com,
Gavin Hu <gavin.hu@arm.com>
Subject: [dpdk-dev] [PATCH v3 2/6] test/spinlock: remove 1us delay for correct benchmarking
Date: Thu, 27 Dec 2018 12:13:45 +0800 [thread overview]
Message-ID: <20181227041349.3058-3-gavin.hu@arm.com> (raw)
In-Reply-To: <20181227041349.3058-1-gavin.hu@arm.com>
The test is to benchmark the performance of spinlock by counting the
number of spinlock acquire and release operations within the specified
time.
A typical pair of lock and unlock operations costs tens or hundreds of
nano seconds, in comparison to this, delaying 1 us outside of the locked
region is too much, compromising the goal of benchmarking the lock and
unlock performance.
Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Ruifeng Wang <Ruifeng.Wang@arm.com>
Reviewed-by: Joyce Kong <Joyce.Kong@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Reviewed-by: Ola Liljedahl <Ola.Liljedahl@arm.com>
---
test/test/test_spinlock.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c
index 73bff128e..6795195ae 100644
--- a/test/test/test_spinlock.c
+++ b/test/test/test_spinlock.c
@@ -120,8 +120,6 @@ load_loop_fn(void *func_param)
lcount++;
if (use_lock)
rte_spinlock_unlock(&lk);
- /* delay to make lock duty cycle slighlty realistic */
- rte_delay_us(1);
time_diff = rte_get_timer_cycles() - begin;
}
lock_count[lcore] = lcount;
--
2.11.0
next prev parent reply other threads:[~2018-12-27 4:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 4:13 [dpdk-dev] [PATCH v3 0/6] spinlock optimization and test case enhancements Gavin Hu
2018-12-27 4:13 ` [dpdk-dev] [PATCH v3 1/6] eal: fix clang compilation error on x86 Gavin Hu
2018-12-27 6:36 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2018-12-27 4:13 ` Gavin Hu [this message]
2018-12-27 7:20 ` [dpdk-dev] [EXT] [PATCH v3 2/6] test/spinlock: remove 1us delay for correct benchmarking Jerin Jacob Kollanukkaran
2018-12-27 4:13 ` [dpdk-dev] [PATCH v3 3/6] test/spinlock: get timestamp more precisely Gavin Hu
2018-12-27 7:27 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-03 18:22 ` Honnappa Nagarahalli
2018-12-27 4:13 ` [dpdk-dev] [PATCH v3 4/6] test/spinlock: amortize the cost of getting time Gavin Hu
2018-12-27 4:13 ` [dpdk-dev] [PATCH v3 5/6] spinlock: reimplement with atomic one-way barrier builtins Gavin Hu
2018-12-27 7:42 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2018-12-27 9:02 ` Gavin Hu (Arm Technology China)
2019-01-03 20:35 ` Honnappa Nagarahalli
2019-01-11 13:52 ` Gavin Hu (Arm Technology China)
2019-01-14 5:54 ` Honnappa Nagarahalli
2019-01-14 7:39 ` Jerin Jacob Kollanukkaran
2019-01-14 17:08 ` Gavin Hu (Arm Technology China)
2019-01-14 7:57 ` Gavin Hu (Arm Technology China)
2018-12-27 4:13 ` [dpdk-dev] [PATCH v3 6/6] spinlock: ticket based to improve fairness Gavin Hu
2018-12-27 6:58 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2018-12-27 10:05 ` Gavin Hu (Arm Technology China)
2018-12-27 12:08 ` Jerin Jacob Kollanukkaran
2018-12-27 23:41 ` Stephen Hemminger
2018-12-28 4:39 ` Jerin Jacob Kollanukkaran
2018-12-28 10:04 ` Gavin Hu (Arm Technology China)
2019-01-03 18:35 ` Honnappa Nagarahalli
2019-01-03 19:53 ` Stephen Hemminger
2019-01-04 7:06 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227041349.3058-3-gavin.hu@arm.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).