From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98545A0561; Tue, 21 Apr 2020 04:36:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64BCC1D6A5; Tue, 21 Apr 2020 04:36:04 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 06CB11D691 for ; Tue, 21 Apr 2020 04:36:01 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 93B1E5C01D1; Mon, 20 Apr 2020 22:36:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 20 Apr 2020 22:36:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0A0GadWCyCZ4EG1DR0PoZZO9Ret6zWJnQOBa4TmyfdM=; b=iouxDBKKXtLiBR4v bk+a6UgaRWxiVnjtz2pJ3Y7gdQOaxDLjsSLjL0veZAdQ7v7shzMSUxr3BTdmgW7z NsvM2YXtCao4khvr8nMNMipkC0IwfPa4CtjEbdhHiBGgzkw3lwuziZkZKua1pcfx kXVOZhqZPMKv8SIY3mYZRc2Z8pYe7ottEN2khx/yN/NvnFALcFB49uIo9x99JQVY ySqFE1/4opkD8az1b6trTKfvAqR6gHK/MYwhUOSNhhSrow2NW/NE3xfwR+GUsF97 9jpqUdLjZgeY3sMSB69Z8k9PTrXbxPa/o6/OzQdtk7zGmUlIhdj2m1C5we39gX75 +gJE7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0A0GadWCyCZ4EG1DR0PoZZO9Ret6zWJnQOBa4Tmyf dM=; b=0/vhx8QvhllwLSpYA3sYJAYEJZom9UunEj6NvwG5dQko9KviBMjLNHwUF OnAdWu27aGhF8fycgYy17nl3C2EQsSEwU22f6CoxKmU2F5toyq6IDXPkRTYgR++O /UScPdqeHN1xEC15o2R3//qok4fDZpbhuUCkxJyuVMQpTHWh8hTd5lUdJ6/WHPES yGvkaOPIPmebVXZutiK+J7jG+fLl2g/UJ7JgkqVShS0kcar1JUWrvy7HePvQOJkx wxixI0UM5+pmSedxsqpvIi+WrCb7VGXPVe6Yrc22i0idJURmV/M5eigI97nsJCan gctkhya5htU+gVj6rpCZljm9FG+GQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeeggdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8870F328005E; Mon, 20 Apr 2020 22:36:00 -0400 (EDT) From: Thomas Monjalon To: akhil.goyal@nxp.com, konstantin.ananyev@intel.com, Savinay Dharmappa Cc: dev@dpdk.org, david.marchand@redhat.com Date: Tue, 21 Apr 2020 04:35:58 +0200 Message-ID: <2018185.irdbgypaU6@thomas> In-Reply-To: <4223016.LvFx2qVVIh@thomas> References: <20200305071523.30952-1-savinay.dharmappa@intel.com> <20200306070825.19424-1-savinay.dharmappa@intel.com> <4223016.LvFx2qVVIh@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2020 04:29, Thomas Monjalon: > 06/03/2020 08:08, Savinay Dharmappa: > > test app to measures the performance of libipsec > > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > Please make sentences in commit logs. > > > Signed-off-by: Savinay Dharmappa > > Acked-by: Konstantin Ananyev > > --- > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/ > > M: Bernard Iremonger > > F: app/test/test_ipsec.c > > F: doc/guides/prog_guide/ipsec_lib.rst > > +M: Savinay Dharmappa > > +F: app/test/test_ipsec_perf.c > > M: Vladimir Medvedkin > > F: app/test/test_ipsec_sad.c > > F: app/test-sad/ > > Repeating what I said on v3: > Having one different maintainer per test file is quite ridiculous. > The maintainers of a lib are expected to maintain the related tests. In addition, reading the first lines of the file, I see two mistakes: > --- /dev/null > +++ b/app/test/test_ipsec_perf.c > @@ -0,0 +1,619 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2014 Intel Corporation The Copyright year should be 2020 I guess. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include rte_malloc.h is already included 3 lines above. I have a bad feeling about this patch, I think it should be dropped from 20.05-rc1.