From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 7157A3B5 for ; Wed, 17 Dec 2014 01:02:40 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id k14so2656576wgh.15 for ; Tue, 16 Dec 2014 16:02:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=G9EdzZp9Ebn/n7gwlb2IhTjxo1feg3j7tcQ2Z89CabQ=; b=LARkYKwzl65iK+mqPlyWZj+V9CmCpEQ6PfLBecX+yCgsiF3wgy3BovNHbn+aO7ULQV bKU4OSvj9HytkHpbobrav1z12hg6jeTqkVomxfGluwADIpeC6HD85LXevXXYcv6cQF8Q RlPV1xE9EccxeuZue4EKVJBKFgc4PBUg6XxjxuuD/LcC35+pR4jGBmNmnGXgRCuEaeuu plMYw6soAwseZvI7R/p/4rej44aCjduSh1HKzgaWAB6nPJKEaojoLzWsi2E8duiSQleY EKM+9aCij2eHyqzDocSjvW6lHvvIjGVYfJV5rG2bEGOWZCYCYfAp8BSuU+H6NEM67XhW wmBA== X-Gm-Message-State: ALoCoQnPRUBuR2O9LhrHphtBic4WtmbedpJYEuzs/pJq9hmJ0HGwvolHjGo8HeDc4bNNeApuAmnm X-Received: by 10.180.8.70 with SMTP id p6mr9216405wia.72.1418774560186; Tue, 16 Dec 2014 16:02:40 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gs9sm2905729wjc.47.2014.12.16.16.02.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 16:02:39 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 17 Dec 2014 01:02:13 +0100 Message-ID: <2018770.F7AcEz4Xgs@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141211170720.GA11672@bricha3-MOBL3> References: <533710CFB86FA344BFBF2D6802E60286C9D147@SHSMSX101.ccr.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831FE4C138@IRSMSX109.ger.corp.intel.com> <20141211170720.GA11672@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 00:02:41 -0000 2014-12-11 17:07, Bruce Richardson: > On Thu, Dec 11, 2014 at 04:58:42PM +0000, Pattan, Reshma wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > When using multiple processes, the TX function used in all processes should be > > > the same, otherwise the secondary processes cannot transmit more than tx- > > > ring-size - 1 packets. > > > To achieve this, we extract out the code to select the ixgbe TX function to be > > > used into a separate function inside the ixgbe driver, and call that from a > > > secondary process when it is attaching to an already-configured NIC. > > > > > > Testing with symmetric MP app shows that we are able to RX and TX from both > > > primary and secondary processes once this patch is applied. > > > > > > Signed-off-by: Bruce Richardson > > > > > > ---- > > > V2 Changes: > > > * Moved check for primary/secondary process into set_tx_function instead > > > of ixgbe_txq_vec_setup, which reduces scope of diff. > > > * Added/cleaned up some code comments for this change > > > --- > > Acked-by: Reshma Pattan > > With comment " checkpatch shows whitespace errors which got copied from old code" > > Thomas, can you fix the whitespace problems when you apply, or do you want a V3? Applied with whitespace changes. Thanks -- Thomas