[dpdk-dev] [PATCH] net/fm10k: initialize sm_down variable

[dpdk-dev] [PATCH] net/fm10k: initialize sm_down variable

[Julien Meunier]

Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
Cc: stable@dpdk.org

Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
---
 drivers/net/fm10k/fm10k_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 85fb6c5..caf4d1b 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
 	hw->bus.payload = fm10k_bus_payload_256;
 
 	info->rx_vec_allowed = true;
+	info->sm_down = false;
 }
 
 static int
-- 
2.10.2

Re: [dpdk-dev] [PATCH] net/fm10k: initialize sm_down variable

[Wang, Xiao W]

Hi Julien,

> -----Original Message-----
> From: Julien Meunier [mailto:julien.meunier@nokia.com]
> Sent: Wednesday, January 2, 2019 11:58 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/fm10k: initialize sm_down variable
> 
> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
> ---
>  drivers/net/fm10k/fm10k_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 85fb6c5..caf4d1b 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
>  	hw->bus.payload = fm10k_bus_payload_256;
> 
>  	info->rx_vec_allowed = true;
> +	info->sm_down = false;
>  }
> 
>  static int
> --
> 2.10.2

Acked-by: Xiao Wang <xiao.w.wang@intel.com>

BRs,
Xiao

Re: [dpdk-dev] [PATCH] net/fm10k: initialize sm_down variable

[Zhang, Qi Z]

> -----Original Message-----
> From: Wang, Xiao W
> Sent: Thursday, January 3, 2019 10:10 AM
> To: Julien Meunier <julien.meunier@nokia.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
> 
> Hi Julien,
> 
> > -----Original Message-----
> > From: Julien Meunier [mailto:julien.meunier@nokia.com]
> > Sent: Wednesday, January 2, 2019 11:58 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> > <xiao.w.wang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH] net/fm10k: initialize sm_down variable
> >
> > Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
> > ---
> >  drivers/net/fm10k/fm10k_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> > b/drivers/net/fm10k/fm10k_ethdev.c
> > index 85fb6c5..caf4d1b 100644
> > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
> >  	hw->bus.payload = fm10k_bus_payload_256;
> >
> >  	info->rx_vec_allowed = true;
> > +	info->sm_down = false;
> >  }
> >
> >  static int
> > --
> > 2.10.2
> 
> Acked-by: Xiao Wang <xiao.w.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

> 
> BRs,
> Xiao

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/fm10k: initialize sm_down variable

[Ferruh Yigit]

On 1/4/2019 1:04 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Wang, Xiao W
>> Sent: Thursday, January 3, 2019 10:10 AM
>> To: Julien Meunier <julien.meunier@nokia.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>>
>> Hi Julien,
>>
>>> -----Original Message-----
>>> From: Julien Meunier [mailto:julien.meunier@nokia.com]
>>> Sent: Wednesday, January 2, 2019 11:58 PM
>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
>>> <xiao.w.wang@intel.com>
>>> Cc: dev@dpdk.org; stable@dpdk.org
>>> Subject: [PATCH] net/fm10k: initialize sm_down variable
>>>
>>> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
>>> ---
>>>  drivers/net/fm10k/fm10k_ethdev.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
>>> b/drivers/net/fm10k/fm10k_ethdev.c
>>> index 85fb6c5..caf4d1b 100644
>>> --- a/drivers/net/fm10k/fm10k_ethdev.c
>>> +++ b/drivers/net/fm10k/fm10k_ethdev.c
>>> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
>>>  	hw->bus.payload = fm10k_bus_payload_256;
>>>
>>>  	info->rx_vec_allowed = true;
>>> +	info->sm_down = false;
>>>  }
>>>
>>>  static int
>>> --
>>> 2.10.2
>>
>> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
> 
> Applied to dpdk-next-net-intel.

Is it possible to add more information to commit log?
What happens if "sm_down" is not initialized? What "sm_down" is for?
Should patch title be a 'fix' patch?

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/fm10k: initialize sm_down variable

[Meunier, Julien (Nokia - FR/Paris-Saclay)]

Hi,

Inline reply,

On 04/01/2019 18:34, Ferruh Yigit wrote:
> On 1/4/2019 1:04 PM, Zhang, Qi Z wrote:
>>
>>
>>> -----Original Message-----
>>> From: Wang, Xiao W
>>> Sent: Thursday, January 3, 2019 10:10 AM
>>> To: Julien Meunier <julien.meunier@nokia.com>; Zhang, Qi Z
>>> <qi.z.zhang@intel.com>
>>> Cc: dev@dpdk.org; stable@dpdk.org
>>> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>>>
>>> Hi Julien,
>>>
>>>> -----Original Message-----
>>>> From: Julien Meunier [mailto:julien.meunier@nokia.com]
>>>> Sent: Wednesday, January 2, 2019 11:58 PM
>>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
>>>> <xiao.w.wang@intel.com>
>>>> Cc: dev@dpdk.org; stable@dpdk.org
>>>> Subject: [PATCH] net/fm10k: initialize sm_down variable
>>>>
>>>> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
>>>> ---
>>>>   drivers/net/fm10k/fm10k_ethdev.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
>>>> b/drivers/net/fm10k/fm10k_ethdev.c
>>>> index 85fb6c5..caf4d1b 100644
>>>> --- a/drivers/net/fm10k/fm10k_ethdev.c
>>>> +++ b/drivers/net/fm10k/fm10k_ethdev.c
>>>> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
>>>>   	hw->bus.payload = fm10k_bus_payload_256;
>>>>
>>>>   	info->rx_vec_allowed = true;
>>>> +	info->sm_down = false;
>>>>   }
>>>>
>>>>   static int
>>>> --
>>>> 2.10.2
>>>
>>> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
>>
>> Applied to dpdk-next-net-intel.
> 
> Is it possible to add more information to commit log?

Sure, no problem.

> What happens if "sm_down" is not initialized? What "sm_down" is for?

sm_down is a boolean in order to check if the internal switch of the 
fm10k is up or down. This variable is configured though an interrupt by 
fm10k_dev_interrupt_handler_pf.

If sm_down is uninitialized, we are not sure of its value at the first 
bring up. For example, if FM10K_EICR_SWITCHREADY is raised, the PMD will 
try to reconfigure the switch, but it does not make sense, as it's the 
first startup.

The sm_down implementation has been introduced here: 6c9f37245583 
("net/fm10k: support switch restart on PF").

> Should patch title be a 'fix' patch?
> 

Mmm, I think yes.

However, my patch has been already merged. Should I need to repush an 
other patch for the stable branches ?

Thanks,
Best regards,
Julien Meunier

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/fm10k: initialize sm_down variable

[Ferruh Yigit]

On 1/7/2019 4:18 PM, Meunier, Julien (Nokia - FR/Paris-Saclay) wrote:
> Hi,
> 
> Inline reply,
> 
> On 04/01/2019 18:34, Ferruh Yigit wrote:
>> On 1/4/2019 1:04 PM, Zhang, Qi Z wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wang, Xiao W
>>>> Sent: Thursday, January 3, 2019 10:10 AM
>>>> To: Julien Meunier <julien.meunier@nokia.com>; Zhang, Qi Z
>>>> <qi.z.zhang@intel.com>
>>>> Cc: dev@dpdk.org; stable@dpdk.org
>>>> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>>>>
>>>> Hi Julien,
>>>>
>>>>> -----Original Message-----
>>>>> From: Julien Meunier [mailto:julien.meunier@nokia.com]
>>>>> Sent: Wednesday, January 2, 2019 11:58 PM
>>>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
>>>>> <xiao.w.wang@intel.com>
>>>>> Cc: dev@dpdk.org; stable@dpdk.org
>>>>> Subject: [PATCH] net/fm10k: initialize sm_down variable
>>>>>
>>>>> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
>>>>> ---
>>>>>   drivers/net/fm10k/fm10k_ethdev.c | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
>>>>> b/drivers/net/fm10k/fm10k_ethdev.c
>>>>> index 85fb6c5..caf4d1b 100644
>>>>> --- a/drivers/net/fm10k/fm10k_ethdev.c
>>>>> +++ b/drivers/net/fm10k/fm10k_ethdev.c
>>>>> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
>>>>>   	hw->bus.payload = fm10k_bus_payload_256;
>>>>>
>>>>>   	info->rx_vec_allowed = true;
>>>>> +	info->sm_down = false;
>>>>>   }
>>>>>
>>>>>   static int
>>>>> --
>>>>> 2.10.2
>>>>
>>>> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
>>>
>>> Applied to dpdk-next-net-intel.
>>
>> Is it possible to add more information to commit log?
> 
> Sure, no problem.
> 
>> What happens if "sm_down" is not initialized? What "sm_down" is for?
> 
> sm_down is a boolean in order to check if the internal switch of the 
> fm10k is up or down. This variable is configured though an interrupt by 
> fm10k_dev_interrupt_handler_pf.
> 
> If sm_down is uninitialized, we are not sure of its value at the first 
> bring up. For example, if FM10K_EICR_SWITCHREADY is raised, the PMD will 
> try to reconfigure the switch, but it does not make sense, as it's the 
> first startup.
> 
> The sm_down implementation has been introduced here: 6c9f37245583 
> ("net/fm10k: support switch restart on PF").
> 
>> Should patch title be a 'fix' patch?
>>
> 
> Mmm, I think yes.
> 
> However, my patch has been already merged. Should I need to repush an 
> other patch for the stable branches ?

Hi Julien,

The patch is not merged into main repo yet, so we can still update it. I will
update it with the information you provided while merging into next-net.

Thanks,
ferruh

> 
> Thanks,
> Best regards,
> Julien Meunier
>