From: Tiwei Bie <tiwei.bie@intel.com>
To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/6] vhost: fix desc access in relay helpers
Date: Fri, 4 Jan 2019 12:06:37 +0800 [thread overview]
Message-ID: <20190104040642.27463-2-tiwei.bie@intel.com> (raw)
In-Reply-To: <20190104040642.27463-1-tiwei.bie@intel.com>
Descs in desc table should be indexed using the desc idx
instead of the idx of avail ring and used ring.
Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay")
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
lib/librte_vhost/vdpa.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index 240a1fe3a..77d92f9ad 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -190,10 +190,10 @@ rte_vdpa_relay_vring_avail(int vid, uint16_t qid, void *vring_m)
if (unlikely(!desc_ring))
return -1;
- if (unlikely(dlen < vq->desc[idx].len)) {
+ if (unlikely(dlen < vq->desc[desc_id].len)) {
idesc = alloc_copy_ind_table(dev, vq,
- vq->desc[idx].addr,
- vq->desc[idx].len);
+ vq->desc[desc_id].addr,
+ vq->desc[desc_id].len);
if (unlikely(!idesc))
return -1;
@@ -279,10 +279,10 @@ rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m)
if (unlikely(!desc_ring))
return -1;
- if (unlikely(dlen < vq->desc[idx].len)) {
+ if (unlikely(dlen < vq->desc[desc_id].len)) {
idesc = alloc_copy_ind_table(dev, vq,
- vq->desc[idx].addr,
- vq->desc[idx].len);
+ vq->desc[desc_id].addr,
+ vq->desc[desc_id].len);
if (unlikely(!idesc))
return -1;
--
2.17.1
next prev parent reply other threads:[~2019-01-04 4:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 4:06 [dpdk-dev] [PATCH 0/6] Some fixes for vhost Tiwei Bie
2019-01-04 4:06 ` Tiwei Bie [this message]
2019-01-04 8:16 ` [dpdk-dev] [PATCH 1/6] vhost: fix desc access in relay helpers Maxime Coquelin
2019-01-04 4:06 ` [dpdk-dev] [PATCH 2/6] vhost: fix possible out of bound " Tiwei Bie
2019-01-04 8:39 ` Maxime Coquelin
2019-01-04 4:06 ` [dpdk-dev] [PATCH 3/6] vhost: fix possible dead loop " Tiwei Bie
2019-01-04 8:40 ` Maxime Coquelin
2019-01-04 4:06 ` [dpdk-dev] [PATCH 4/6] vhost: fix possible out of bound access in vector filling Tiwei Bie
2019-01-04 8:46 ` Maxime Coquelin
2019-01-04 4:06 ` [dpdk-dev] [PATCH 5/6] vhost: fix possible dead loop " Tiwei Bie
2019-01-04 8:46 ` Maxime Coquelin
2019-01-04 4:06 ` [dpdk-dev] [PATCH 6/6] vhost: ensure event idx is mapped when negotiated Tiwei Bie
2019-01-04 8:47 ` Maxime Coquelin
2019-01-04 18:00 ` [dpdk-dev] [PATCH 0/6] Some fixes for vhost Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104040642.27463-2-tiwei.bie@intel.com \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).