DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: [dpdk-dev] [PATCH 4/6] vhost: fix possible out of bound access in vector filling
Date: Fri,  4 Jan 2019 12:06:40 +0800	[thread overview]
Message-ID: <20190104040642.27463-5-tiwei.bie@intel.com> (raw)
In-Reply-To: <20190104040642.27463-1-tiwei.bie@intel.com>

Fixes: 7f74b95c444f ("vhost: pre update used ring for Tx and Rx")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 lib/librte_vhost/virtio_net.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 474acf64d..d64c355b9 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -312,6 +312,9 @@ fill_vec_buf_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
 	struct vring_desc *descs = vq->desc;
 	struct vring_desc *idesc = NULL;
 
+	if (unlikely(idx >= vq->size))
+		return -1;
+
 	*desc_chain_head = idx;
 
 	if (vq->desc[idx].flags & VRING_DESC_F_INDIRECT) {
-- 
2.17.1

  parent reply	other threads:[~2019-01-04  4:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04  4:06 [dpdk-dev] [PATCH 0/6] Some fixes for vhost Tiwei Bie
2019-01-04  4:06 ` [dpdk-dev] [PATCH 1/6] vhost: fix desc access in relay helpers Tiwei Bie
2019-01-04  8:16   ` Maxime Coquelin
2019-01-04  4:06 ` [dpdk-dev] [PATCH 2/6] vhost: fix possible out of bound " Tiwei Bie
2019-01-04  8:39   ` Maxime Coquelin
2019-01-04  4:06 ` [dpdk-dev] [PATCH 3/6] vhost: fix possible dead loop " Tiwei Bie
2019-01-04  8:40   ` Maxime Coquelin
2019-01-04  4:06 ` Tiwei Bie [this message]
2019-01-04  8:46   ` [dpdk-dev] [PATCH 4/6] vhost: fix possible out of bound access in vector filling Maxime Coquelin
2019-01-04  4:06 ` [dpdk-dev] [PATCH 5/6] vhost: fix possible dead loop " Tiwei Bie
2019-01-04  8:46   ` Maxime Coquelin
2019-01-04  4:06 ` [dpdk-dev] [PATCH 6/6] vhost: ensure event idx is mapped when negotiated Tiwei Bie
2019-01-04  8:47   ` Maxime Coquelin
2019-01-04 18:00 ` [dpdk-dev] [PATCH 0/6] Some fixes for vhost Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104040642.27463-5-tiwei.bie@intel.com \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).