From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 72E031B4C6 for ; Fri, 4 Jan 2019 20:35:53 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id u6so17836144plm.8 for ; Fri, 04 Jan 2019 11:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7mhWLsPvCNNG8dZGNmklquENjjSxH6x1ajNuVQ774pg=; b=Pcgu0kcI6WCFXZ3HqG74mzGq7atPzuYZ38j7aply+Uiwcr+Hlic3BhRFHBf+9Uo1ht i0tRttV/Ouv3iTt6PizKEovhsRe7PaUw8PaOcTgckkmvx/qeb8jTGy/zzGXs8ttLhkmG coMmsmyOKoj4DyEN5MT8JtKzNOw81SVfmFo0Z6Du5MfrPIUszxdthzWqhQFz6M6j6cZB HAjeapl2W4dwzAZ0EVfX2m0HqoRLV491+koI1ilhN5fNKXiDkyIssG5FiKdRfhrJPzgH tjWNnfVH2omQd4LmrCyLEGXUoGP/fEZn8N8r8EAQ6ixqVplZuWLD8Bn4PDEOTAlirPLx Ocrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7mhWLsPvCNNG8dZGNmklquENjjSxH6x1ajNuVQ774pg=; b=TQpducjaRQpubdl0/h6p0fCENexg1eBJ39Cb883IzAdi34OZcsUoTnaTI8tKK4Xvgq 5zYaY3Cy6nCZ8DH3+Eqjp/F9eVdQp+vztWRMPORnALOx5WtH65pmXkqJNo2jn9q73yRf sNqFRN69QdmUzc2pUGWapMMsFgIQMu4UphfmbZAn1Kh21NcTuNCNy3mm5CTHOhYdlJZA AVvDHpU8TQg+YKcmEkPbcpYUcVOLP+wMzEtEAnVaj3wBjpIVT4HK5WaagfVYzkUI0/uy 071bFLftYT1GXxEp2sEN6vlyO5wFcDF8UytyTTa2trK1Ki/GlHxNgLQ0DfENxZOFnX8Y jPpw== X-Gm-Message-State: AJcUukcPQhlXU/wtGIERq2ilQgPpw3LbDWO41NQjUqDwcy3wH/SZ5shK mRLUWD8uGQU7irEjIul8iFFiVA== X-Google-Smtp-Source: ALg8bN5hPl+FhC4Pg8FLGEpLXNBNTrk/GTXM2ruO1XOmRLIOKWNTi1uSUDQ0M4fsDQ4CmtOFCxW0Hw== X-Received: by 2002:a17:902:24d:: with SMTP id 71mr50562443plc.225.1546630552559; Fri, 04 Jan 2019 11:35:52 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u123sm78196942pfb.1.2019.01.04.11.35.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 11:35:52 -0800 (PST) Date: Fri, 4 Jan 2019 11:35:45 -0800 From: Stephen Hemminger To: Jiayu Hu Cc: dev@dpdk.org Message-ID: <20190104113545.7d31a819@hermes.lan> In-Reply-To: <1545107119-85376-1-git-send-email-jiayu.hu@intel.com> References: <1545107119-85376-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: add GRO API requirement in prog_guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 19:35:53 -0000 On Tue, 18 Dec 2018 12:25:19 +0800 Jiayu Hu wrote: > +.. note:: > + To use the GRO library, applications must guarantee that > + MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len and > + MBUF->pkt_len/data_len of input packets are set to correct > + values. > + This statement seems confusing to me since this is Generic Receive Offload, and receive buffers come from the poll mode driver. Aren't you saying that the PMD must set the correct values. If this is correct, then any PMD not doing so is buggy. And should be reported and fixed. If it is really buggy PMD's then the statement in the programmers guide is not the place to handle this kind of issue. Better to just shame the buggy drivers in the release notes for that NIC.