From: Stephen Hemminger <stephen@networkplumber.org>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: cristian.dumitrescu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support
Date: Fri, 4 Jan 2019 11:42:35 -0800 [thread overview]
Message-ID: <20190104114235.228a31f9@hermes.lan> (raw)
In-Reply-To: <154661038141.75321.10886021990395716851.stgit@dbuild>
On Fri, 4 Jan 2019 13:59:42 +0000
Eelco Chaudron <echaudro@redhat.com> wrote:
> This patch adds support for RFC4115 trTCM meters.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Fix comment formatting.
### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#172: FILE: lib/librte_meter/rte_meter.h:59:
+/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS
+parameters only count bytes of IP packets and do not include link specific
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: lib/librte_meter/rte_meter.h:61:
+none-zero respectively.*/
WARNING:LONG_LINE_COMMENT: line over 80 characters
#176: FILE: lib/librte_meter/rte_meter.h:63:
+ uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */
WARNING:LONG_LINE_COMMENT: line over 80 characters
#177: FILE: lib/librte_meter/rte_meter.h:64:
+ uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */
WARNING:LONG_LINE_COMMENT: line over 80 characters
#355: FILE: lib/librte_meter/rte_meter.h:406:
+ /**< Number of bytes currently available in the excess(E) token bucket */
total: 0 errors, 5 warnings, 356 lines checked
next prev parent reply other threads:[~2019-01-04 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 13:59 [dpdk-dev] [PATCH v4 0/2] " Eelco Chaudron
2019-01-04 13:59 ` [dpdk-dev] [PATCH v4 1/2] " Eelco Chaudron
2019-01-04 19:42 ` Stephen Hemminger [this message]
2019-01-07 7:41 ` Eelco Chaudron
2019-01-07 15:54 ` Dumitrescu, Cristian
2019-01-04 13:59 ` [dpdk-dev] [PATCH v4 2/2] test/test_meter: update meter test to include RFC4115 meters Eelco Chaudron
2019-01-07 15:58 ` [dpdk-dev] [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support Dumitrescu, Cristian
2019-01-09 23:22 ` Thomas Monjalon
2019-01-10 8:25 ` Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104114235.228a31f9@hermes.lan \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).