From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D3C0B1B4BA for ; Fri, 4 Jan 2019 20:42:42 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id i12so18745909pfo.7 for ; Fri, 04 Jan 2019 11:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O5na22MM+3tyZX70w7EGjiQr3sXnk3eqqb7L4iLtln8=; b=PKx7NLwnurLwaU+RpZFKQi9i5OE2qYdwUoseTGDW8ZJahTrSiFmJ6aHBy7yXbKJ6V8 BoAkSaRiDHNbSTUYASllwn4tRb8ikwhAw1xqrH+zcFlue11orLOVTUgKWQXgnCxUkY+U wpNBzwpKamLmnNPpQOBu6GGoBC5JCFXoJ7ozUG2bt1/IiN+WwO8BVrs8N+3Sw3o/DGvY f7L6qdVDbuy0pj2w0BHOCx30g2BjGqTEhgEdsGRtbjr2fs5093GFrWqvuSZN+wowTulQ gJMsTe5cXK5ny1IZl7gAGHVEkneckAv7vPOA+WXF2lNX2ullM7Jy3tK0jOsr/+rZbner onWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O5na22MM+3tyZX70w7EGjiQr3sXnk3eqqb7L4iLtln8=; b=Dwzmw8yzyjYvr61ZZzDRDurj2tL9XAt3XZ7aKNnsDkaejuiOg3+nykkiFtAhkLDdia xA6Vivx7EYNW15J3gEbURFRj6viwN12whkjKdu0nynawDX6ErolbDCt1QhCUEzVH53AL qInjzPD/hm3bJuDwszYJgnTol60IX2sL5kq7vl0EOHjb94SQhRBl9HglYOhXIKXmf7f/ JUpY6y2evnvxCmHuovUh/ot7HGNI+Zuc+cLl85SKrDWfZ+iYIdgASjyGu2osM8oO/fI6 9/ewsWcC+ts+fMLbV3BxJUmn24TmFpLtI29gUlRX8TMtsEQ2MZSVPhjvMJMYSZ2TyoQr qimg== X-Gm-Message-State: AA+aEWYI374MdJFPEnkTTwUtEFSvUgCOEmiceawrXYRDjJyKpOFuvte5 rFq7SbyFlYzbqpFm4mO7MEG/aw== X-Google-Smtp-Source: AFSGD/U8LHFW4f87buhR+orvIdlkzNBfjSZesrq1Cpzwgr/oW4dUMLcYGdbNphMvH+hnVQsVQEH7pw== X-Received: by 2002:a62:4bcf:: with SMTP id d76mr55918250pfj.170.1546630961979; Fri, 04 Jan 2019 11:42:41 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u123sm78209633pfb.1.2019.01.04.11.42.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 11:42:41 -0800 (PST) Date: Fri, 4 Jan 2019 11:42:35 -0800 From: Stephen Hemminger To: Eelco Chaudron Cc: cristian.dumitrescu@intel.com, dev@dpdk.org Message-ID: <20190104114235.228a31f9@hermes.lan> In-Reply-To: <154661038141.75321.10886021990395716851.stgit@dbuild> References: <154661036216.75321.4852909033090962683.stgit@dbuild> <154661038141.75321.10886021990395716851.stgit@dbuild> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 19:42:43 -0000 On Fri, 4 Jan 2019 13:59:42 +0000 Eelco Chaudron wrote: > This patch adds support for RFC4115 trTCM meters. > > Signed-off-by: Eelco Chaudron Fix comment formatting. ### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #172: FILE: lib/librte_meter/rte_meter.h:59: +/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS +parameters only count bytes of IP packets and do not include link specific WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #174: FILE: lib/librte_meter/rte_meter.h:61: +none-zero respectively.*/ WARNING:LONG_LINE_COMMENT: line over 80 characters #176: FILE: lib/librte_meter/rte_meter.h:63: + uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */ WARNING:LONG_LINE_COMMENT: line over 80 characters #177: FILE: lib/librte_meter/rte_meter.h:64: + uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */ WARNING:LONG_LINE_COMMENT: line over 80 characters #355: FILE: lib/librte_meter/rte_meter.h:406: + /**< Number of bytes currently available in the excess(E) token bucket */ total: 0 errors, 5 warnings, 356 lines checked