From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A47B31B4A2; Mon, 7 Jan 2019 13:24:06 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 04:24:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208";a="106198387" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga006.jf.intel.com with SMTP; 07 Jan 2019 04:24:03 -0800 Received: by (sSMTP sendmail emulation); Mon, 07 Jan 2019 12:24:01 +0000 Date: Mon, 7 Jan 2019 12:24:01 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, stable@dpdk.org Message-ID: <20190107122401.GA14912@bricha3-MOBL.ger.corp.intel.com> References: <20181224125627.25690-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181224125627.25690-1-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 12:24:07 -0000 On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote: > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. > > Force the default flags if the user explicitly sets marchine=default typo: marchine > at configuration time. > > Fixes: b1d48c41189a ("build: support ARM with meson") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi > --- > config/arm/meson.build | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index dae55d6b2..fa21a2fd2 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -6,6 +6,7 @@ > march_opt = '-march=@0@'.format(machine) > > arm_force_native_march = false > +arm_force_default_march = machine == 'default' Do we need a new variable here? Given it only seems to be used once below, I think just having the boolean expression directly in the if statement is clearer. If you do keep the variable, suggest putting braces around the comparison, otherwise at first glance it looks like a chained assignment like you get in C e.g. x = y = 0; > > machine_args_generic = [ > ['default', ['-march=armv8-a+crc+crypto']], > @@ -105,7 +106,11 @@ else > cmd_generic = ['generic', '', '', 'default', ''] > cmd_output = cmd_generic # Set generic by default > machine_args = [] # Clear previous machine args > - if not meson.is_cross_build() > + if arm_force_default_march and not meson.is_cross_build() > + machine = impl_generic > + cmd_output = cmd_generic > + impl_pn = 'default' > + elif not meson.is_cross_build() > # The script returns ['Implementer', 'Variant', 'Architecture', > # 'Primary Part number', 'Revision'] > detect_vendor = find_program(join_paths( > -- > 2.19.2 > With these comments, looks ok to me from a meson viewpoint. I think an ack from the arm side would be good to get too though. Acked-by: Bruce Richardson