From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9F49B1B442; Mon, 7 Jan 2019 17:49:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 08:49:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,451,1539673200"; d="scan'208";a="123958632" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2019 08:49:48 -0800 From: Ferruh Yigit To: Ferruh Yigit , Thomas Monjalon , John McNamara , Marko Kovacevic Cc: dev@dpdk.org, stable@dpdk.org, Tom Barbette , Yongseok Koh , Konstantin Ananyev , Bruce Richardson , Vipin Varghese Date: Mon, 7 Jan 2019 16:49:42 +0000 Message-Id: <20190107164942.88785-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190103162313.85623-1-ferruh.yigit@intel.com> References: <20190103162313.85623-1-ferruh.yigit@intel.com> Subject: [dpdk-dev] [PATCH v4] mk: fix scope of disabling AVX512F support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 16:49:53 -0000 AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88096 Fixes: 8d07c82b239f ("mk: disable gcc AVX512F support") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: Tom Barbette Cc: Thomas Monjalon Cc: Yongseok Koh Cc: Konstantin Ananyev Cc: Bruce Richardson v2: * Added warning message (print only once for eal) * Moved decision details to compat file, kept execution in cpuflags v3: * replace 'ld' with '$(LD)' for cross build * added meson support v4: * Document this limitation in release notes Cc: Vipin Varghese --- config/meson.build | 8 ++++++ doc/guides/rel_notes/known_issues.rst | 32 ++++++++++++++++++++++++ doc/guides/rel_notes/release_19_02.rst | 13 ++++++++++ mk/rte.cpuflags.mk | 4 +-- mk/toolchain/gcc/rte.toolchain-compat.mk | 10 ++++++++ 5 files changed, 65 insertions(+), 2 deletions(-) diff --git a/config/meson.build b/config/meson.build index db32499b3..40802fc88 100644 --- a/config/meson.build +++ b/config/meson.build @@ -43,6 +43,14 @@ toolchain = cc.get_id() dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain) dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) +# get binutils version for the workaround of Bug 97 +ldver = run_command('ld', '-v').stdout().strip() +if ldver.contains('2.30') + if cc.has_argument('-mno-avx512f') + machine_args += '-mno-avx512f' + endif +endif + add_project_link_arguments('-Wl,--no-as-needed', language: 'c') dpdk_extra_ldflags += '-Wl,--no-as-needed' diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index a1face9c1..b0057a2bc 100644 --- a/doc/guides/rel_notes/known_issues.rst +++ b/doc/guides/rel_notes/known_issues.rst @@ -826,3 +826,35 @@ Kernel crash when hot-unplug igb_uio device while DPDK application is running **Driver/Module**: ``igb_uio`` module. + + +AVX-512 support disabled +------------------------ + +**Description**: + ``AVX-512`` support has been disabled on some conditions. + This shouldn't be confused with ``CONFIG_RTE_ENABLE_AVX512`` config option which is already + disabled by default. This config option defines if ``AVX-512`` specific implementations of + some file to be used or not. What has been disabled is compiler feature to produce ``AVX-512`` + instructions from any source code. + + On DPDK v18.11 ``AVX-512`` disabled for all ``GCC`` builds which reported to cause a performance + drop. + + On DPDK v19.02 ``AVX-512`` disable scope reduced to ``GCC`` and ``binutils version 2.30`` based + on information accured from the GCC community defect. + +**Reason**: + Generated ``AVX-512`` code cause crash: + https://bugs.dpdk.org/show_bug.cgi?id=97 + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88096 + +**Resolution/Workaround**: + Update ``binutils`` to newer version than ``2.30``. + Use different compiler, like ``clang`` for this case. + +**Affected Environment/Platform**: + ``GCC`` and ``binutils version 2.30``. + +**Driver/Module**: + ALL. diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst index 39c6ff826..b6322b282 100644 --- a/doc/guides/rel_notes/release_19_02.rst +++ b/doc/guides/rel_notes/release_19_02.rst @@ -276,6 +276,19 @@ Known Issues Also, make sure to start the actual text at the margin. ========================================================= +* ``AVX-512`` support has been disabled for ``GCC`` builds when ``binutils 2.30`` + is detected [1] because of a crash [2]. This can affect ``native`` machine type + build targets on the platforms that support ``AVX512F`` like ``Intel Skylake`` + processors, and can cause a possible performance drop. The immediate workaround + is to use ``clang`` compiler on these platforms. + Initial workaround in DPDK v18.11 was to disable ``AVX-512`` support for ``GCC`` + completely, but based on information on defect submitted to GCC community [3], + issue has been identified as ``binutils 2.30`` issue. Since currently only GCC + generates ``AVX-512`` instructions, scope limited to ``GCC`` and ``binutils 2.30`` + + - [1]: Commit ("mk: fix scope of disabling AVX512F support") + - [2]: https://bugs.dpdk.org/show_bug.cgi?id=97 + - [3]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88096 Tested Platforms ---------------- diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index c3291b17a..541211c61 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -69,8 +69,8 @@ ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS += AVX512F else -# disable AVX512F support of gcc as a workaround for Bug 97 -ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) +# disable AVX512F support for GCC & binutils 2.30 as a workaround for Bug 97 +ifeq ($(FORCE_DISABLE_AVX512),y) MACHINE_CFLAGS += -mno-avx512f endif endif diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index 44904295c..33ea3f03a 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -20,6 +20,16 @@ HOST_GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(HOSTCC) -E -x c - | tail -n 1) HOST_GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(HOSTCC) -E -x c - | tail -n 1) HOST_GCC_VERSION = $(HOST_GCC_MAJOR)$(HOST_GCC_MINOR) +LD_VERSION = $(shell $(LD) -v) +# disable AVX512F support for GCC & binutils 2.30 as a workaround for Bug 97 +ifneq ($(filter 2.30%,$(LD_VERSION)),) +FORCE_DISABLE_AVX512 := y +# print warning only once for librte_eal +ifneq ($(filter %librte_eal,$(lastword $(CURDIR))),) +$(warning AVX512 support disabled because of ld 2.30. See Bug 97) +endif +endif + # if GCC is older than 4.x ifeq ($(shell test $(GCC_VERSION) -lt 40 && echo 1), 1) MACHINE_CFLAGS = -- 2.17.2