From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30086.outbound.protection.outlook.com [40.107.3.86]) by dpdk.org (Postfix) with ESMTP id 8D9301B3B8 for ; Tue, 8 Jan 2019 09:34:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0JGvTOyURloW9Id+gEF1MKnhI7RFec1rXRbdcFqkQqA=; b=yG01XjkQ29C1CUaMAS+/e17LPUxGAKnn95YP4T4UMGOrIB1u6KxUvkkSmV3WgsqiMEBMPaN9uoOhUtARQ8tcxX8joV5Gr4N/23ruslVvn892SYPA1tUWMkNuCdtBKh699pMyaxQeVHyds4u0PoXWt3w4LaM9z4AkolxHDIlR1s8= Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (20.179.6.215) by AM6PR05MB4136.eurprd05.prod.outlook.com (52.135.160.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Tue, 8 Jan 2019 08:34:11 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::c12e:7797:8834:9734]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::c12e:7797:8834:9734%3]) with mapi id 15.20.1516.010; Tue, 8 Jan 2019 08:34:11 +0000 From: Jack Min To: Ori Kam CC: Dekel Peled , Adrien Mazarguil , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation Thread-Index: AQHUpyztImFKEXCnYUK8qOIaYaXrxg== Date: Tue, 8 Jan 2019 08:34:11 +0000 Message-ID: <20190108083356.vx73m6ag7lqc2pco@MTBC-JACKMIN.mtl.com> References: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2P15301CA0023.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::33) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [42.120.102.175] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB4136; 6:gm0bIM0AJkSTXe+ay7LJog44N9+L5PcBtIumTMbtVV/v75X3KDOYXSUqzIx78/EXKZ1uR6AXjqG59VPgDDtDS2OYe802qMbZPFv5G+tAbCb6irBrmCmQdEa+5cegC5rZpZdW81oYuiE9nNvACK015ryzaHFqFtjG5PEtje8YRxcOOoec3L9OiEwqm3kfc0277lN8HSGlBDWPkyhUwqXXElVZCjMlnonMsBWm4nzvujG7vvnSruswU1A2sa95ns7ciI6+C/D0V1gv4VfqOecWX84GRMQeR5ULc+d4Ta44P+nAlHz/509pjMGfj3mK5nEnliBGnslCOWVMaOQ7iroZXpecsTGBHc2m5AYh/xR2L5fF4fO4lTyVtARM+ehJ7JEL9UHNJZWxGq3PhAuHej208NRuGz3A7TLDbcLyk1z/AdfWYMvHY0GlinyMk0U7Zwhs9jO/TokVi3iW2bfXPIDVgw==; 5:y20mZiVeVus6+Sfr9YP423HrwEZSDgu+xHWeAq2Xgj0GiMty+soPpEqTIzD6mh9YCgNxHiPCq+e5/0/qMHcoFY8cmyqNvsrfhsqsx7TVoZfE0YCnAF4cxEw3H4SmLr43HnDbGrE73eMLY/65iXdFh7Vtqu1SrmWyUBgNrvy37QY4EG0AXwkkax5ATA/mlO2WjAEhZi1azevQBBxbqG1sFQ==; 7:RzzQ+/fNHfOhx8BwuUEcSlUWucCfdFzxm55J92rUIW3JTjYjtceXTiLhcf5l5kHKVILxE2gOriKJvBHpJF/TzN8y2f+C1Sz07oqLUssFgXEN4/qjfQiQRP/Y/5fH4q2zVAaJW8wg5cIRA9m21VH2Hg== x-ms-office365-filtering-correlation-id: 2af7f66d-d82a-4964-b14a-08d67544104f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB4136; x-ms-traffictypediagnostic: AM6PR05MB4136: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:AM6PR05MB4136; BCL:0; PCL:0; RULEID:; SRVR:AM6PR05MB4136; x-forefront-prvs: 0911D5CE78 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(366004)(396003)(39860400002)(199004)(189003)(13464003)(6862004)(9686003)(6512007)(81156014)(68736007)(81166006)(8936002)(6636002)(6246003)(4326008)(3846002)(6116002)(229853002)(105586002)(25786009)(6436002)(97736004)(71200400001)(53936002)(71190400001)(106356001)(1076003)(6486002)(33896004)(76176011)(102836004)(2906002)(53546011)(6506007)(386003)(26005)(478600001)(186003)(54906003)(14454004)(86362001)(316002)(66066001)(8676002)(486006)(305945005)(7736002)(256004)(5660300001)(476003)(99286004)(11346002)(446003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB4136; H:AM6PR05MB6567.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: g7ASdzzfp7PhLJE7deBU9mWWpffJU0HolpZhe9Bwj1Hpn92MTDnXzeN4P6PKQFFVEXIuH+7VEinflDa5yyYQKcPo3mbRrbAB9HtuK1M88t4x2hhQx8s2qpgghkcKgIFxhjNIym1rSnZSUDxqzGdjiCtroEojImIQUOmhru9YyT5iCtxE5QZlWDKAiTgJwbAjrqtw5liTgr8bpeyq+A+Gcmuxng+vMrCF11tc5u29FrPeoi0105YH2R/mOnCrzp2W8V8fgZXn2k807FC5kTYb3s93hSTybDycrIZvXj/6CrfcJkXweZBS2FzIHbrnLE3s spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af7f66d-d82a-4964-b14a-08d67544104f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2019 08:34:09.4495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4136 Subject: Re: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 08:34:13 -0000 On 19-01-03 22:20:58, Ori Kam wrote: > PSB >=20 > > -----Original Message----- > > From: dev On Behalf Of Dekel Peled > > Sent: Thursday, January 3, 2019 3:09 PM > > To: Adrien Mazarguil > > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > ; Jack Min > > Subject: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions > > documentation > >=20 > > This patch fixes a typo in SET_MAC_DST action description. > > It also adds restriction note for set MAC src/dst actions description. > >=20 > > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") > > Cc: jackmin@mellanox.com > >=20 > > Signed-off-by: Dekel Peled > > --- > > doc/guides/prog_guide/rte_flow.rst | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > >=20 > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index c186375..df1ac2f 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -2314,7 +2314,10 @@ in pattern, Some PMDs will reject rule because > > behaviour will be undefined. > > Action: ``SET_MAC_SRC`` > > ^^^^^^^^^^^^^^^^^^^^^^^ > >=20 > > -Set source MAC address > > +Set source MAC address in the outermost Ethernet header. >=20 > This line is incorrect in case we have encap action the modified MAC will= be the inner. >=20 Ori, I think it more likes PMD-specific behaviour and not for API in genera= l. What do you think ?=20 > > + > > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > >=20 > > .. _table_rte_flow_action_set_mac_src: > >=20 > > @@ -2329,7 +2332,10 @@ Set source MAC address > > Action: ``SET_MAC_DST`` > > ^^^^^^^^^^^^^^^^^^^^^^^ > >=20 > > -Set source MAC address > > +Set destination MAC address in the outermost Ethernet header. >=20 > This line is incorrect in case we have encap action the modified MAC will= be the inner. >=20 > > + > > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > >=20 > > .. _table_rte_flow_action_set_mac_dst: > >=20 > > -- > > 1.8.3.1 >=20 >=20 > Thanks, > Ori