From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] config: gather options for dlopen mlx dependency
Date: Wed, 9 Jan 2019 09:33:45 +0000 [thread overview]
Message-ID: <20190109093345.GA2940@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190109020524.3633-1-thomas@monjalon.net>
On Wed, Jan 09, 2019 at 03:05:23AM +0100, Thomas Monjalon wrote:
> Rename options CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS and
> CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS to a single option
> CONFIG_RTE_IBVERBS_LINK_DLOPEN.
> Rename meson option enable_driver_mlx_glue to ibverbs_link.
>
> There was no good reason for setting a different link option
> for mlx4 and mlx5. Having a single common option makes it
> easier to understand and unify make and meson systems.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> config/common_base | 7 +++++--
> doc/guides/nics/mlx4.rst | 4 ++--
> doc/guides/nics/mlx5.rst | 4 ++--
> drivers/net/mlx4/Makefile | 8 ++++----
> drivers/net/mlx4/meson.build | 4 ++--
> drivers/net/mlx4/mlx4.c | 4 ++--
> drivers/net/mlx5/Makefile | 8 ++++----
> drivers/net/mlx5/meson.build | 4 ++--
> drivers/net/mlx5/mlx5.c | 4 ++--
> meson_options.txt | 4 ++--
> mk/rte.app.mk | 15 +++++++--------
> 11 files changed, 34 insertions(+), 32 deletions(-)
>
<snip>
> diff --git a/meson_options.txt b/meson_options.txt
> index 10b541615..fab97591a 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -2,8 +2,8 @@ option('allow_invalid_socket_id', type: 'boolean', value: false,
> description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly')
> option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
> description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
> -option('enable_driver_mlx_glue', type: 'boolean', value: false,
> - description: 'Enable glue library for Mellanox PMDs')
> +option('ibverbs_link', type: 'string', value: 'shared',
> + description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')
I think it's better to use the "combo" option type here rather than
a generic string. That way we get proper protection against typos when
configuring.
[Ref: https://mesonbuild.com/Build-options.html]
next prev parent reply other threads:[~2019-01-09 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 2:05 Thomas Monjalon
2019-01-09 2:05 ` [dpdk-dev] [PATCH 2/2] config: add static linkage of " Thomas Monjalon
2019-01-09 9:37 ` Bruce Richardson
2019-01-09 10:02 ` Thomas Monjalon
2019-01-09 7:51 ` [dpdk-dev] [PATCH 1/2] config: gather options for dlopen " Shahaf Shuler
2019-01-09 9:33 ` Bruce Richardson [this message]
2019-01-09 9:55 ` Thomas Monjalon
2019-01-09 14:23 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2019-01-09 14:23 ` [dpdk-dev] [PATCH v2 2/2] config: add static linkage of " Thomas Monjalon
2019-01-09 15:03 ` [dpdk-dev] [PATCH v2 1/2] config: gather options for dlopen " Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109093345.GA2940@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).