From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E85921B1E8 for ; Wed, 9 Jan 2019 10:33:49 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 01:33:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,456,1539673200"; d="scan'208";a="265685895" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga004.jf.intel.com with SMTP; 09 Jan 2019 01:33:46 -0800 Received: by (sSMTP sendmail emulation); Wed, 09 Jan 2019 09:33:45 +0000 Date: Wed, 9 Jan 2019 09:33:45 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20190109093345.GA2940@bricha3-MOBL.ger.corp.intel.com> References: <20190109020524.3633-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109020524.3633-1-thomas@monjalon.net> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 1/2] config: gather options for dlopen mlx dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 09:33:50 -0000 On Wed, Jan 09, 2019 at 03:05:23AM +0100, Thomas Monjalon wrote: > Rename options CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS and > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS to a single option > CONFIG_RTE_IBVERBS_LINK_DLOPEN. > Rename meson option enable_driver_mlx_glue to ibverbs_link. > > There was no good reason for setting a different link option > for mlx4 and mlx5. Having a single common option makes it > easier to understand and unify make and meson systems. > > Signed-off-by: Thomas Monjalon > --- > config/common_base | 7 +++++-- > doc/guides/nics/mlx4.rst | 4 ++-- > doc/guides/nics/mlx5.rst | 4 ++-- > drivers/net/mlx4/Makefile | 8 ++++---- > drivers/net/mlx4/meson.build | 4 ++-- > drivers/net/mlx4/mlx4.c | 4 ++-- > drivers/net/mlx5/Makefile | 8 ++++---- > drivers/net/mlx5/meson.build | 4 ++-- > drivers/net/mlx5/mlx5.c | 4 ++-- > meson_options.txt | 4 ++-- > mk/rte.app.mk | 15 +++++++-------- > 11 files changed, 34 insertions(+), 32 deletions(-) > > diff --git a/meson_options.txt b/meson_options.txt > index 10b541615..fab97591a 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -2,8 +2,8 @@ option('allow_invalid_socket_id', type: 'boolean', value: false, > description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly') > option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', > description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.') > -option('enable_driver_mlx_glue', type: 'boolean', value: false, > - description: 'Enable glue library for Mellanox PMDs') > +option('ibverbs_link', type: 'string', value: 'shared', > + description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.') I think it's better to use the "combo" option type here rather than a generic string. That way we get proper protection against typos when configuring. [Ref: https://mesonbuild.com/Build-options.html]