From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6E8981B48D for ; Wed, 9 Jan 2019 15:55:25 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9615C0528BD; Wed, 9 Jan 2019 14:55:24 +0000 (UTC) Received: from redhat.com (ovpn-123-72.rdu2.redhat.com [10.10.123.72]) by smtp.corp.redhat.com (Postfix) with SMTP id A8EFB5D76C; Wed, 9 Jan 2019 14:55:18 +0000 (UTC) Date: Wed, 9 Jan 2019 09:55:18 -0500 From: "Michael S. Tsirkin" To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , Xiao Wang , Tiwei Bie , Zhihong Wang , jfreimann@redhat.com, Jason Wang , xiaolong.ye@intel.com, alejandro.lucero@netronome.com Message-ID: <20190109095445-mutt-send-email-mst@kernel.org> References: <20181226163712.31596-1-i.maximets@samsung.com> <20190109145015.3010-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109145015.3010-1-i.maximets@samsung.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 09 Jan 2019 14:55:24 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 14:55:25 -0000 On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: > Version 3: > * Added 2 patches with fixes for current virtio driver. > Not directly connected with the new feature. New version shouldn't be reply-to old one really :). But the patches are good I think. Acked-by: Michael S. Tsirkin > Version 2: > * rebased on current master (packed rings). > > RFC --> Version 1: > * Dropped vendor-specific hack to determine if we need real barriers. > * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. > > Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER > to VIRTIO_F_ORDER_PLATFORM is not merged yet: > https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html > > Ilya Maximets (3): > net/virtio: add missing barrier before reading the flags > net/virtio: update memory ordering comment for vq notify > net/virtio: add platform memory ordering feature support > > drivers/net/virtio/virtio_ethdev.c | 2 ++ > drivers/net/virtio/virtio_ethdev.h | 3 +- > drivers/net/virtio/virtio_pci.h | 7 ++++ > drivers/net/virtio/virtio_rxtx.c | 16 ++++----- > drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- > 5 files changed, 63 insertions(+), 21 deletions(-) > > -- > 2.17.1