Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Jan 10, 2019 at 11:44:07AM +0100, David Marchand wrote:
>    On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson
>    <[1]bruce.richardson@intel.com> wrote:
> 
>      On Thu, Jan 10, 2019 at 10:34:19AM +0000, Burakov, Anatoly wrote:
>      > On 10-Jan-19 10:02 AM, Bruce Richardson wrote:
>      > > I also forgot that. However, that does bring up the thought that
>      for some
>      > > of our headers we may want them available for all libraries even
>      before EAL
>      > > is compiled up. [I think this hits on the idea Thomas was
>      discussing of
>      > > splitting EAL up into two, where we have a core part that is
>      always
>      > > compiled first and has no dependencies followed by another which
>      is built
>      > > later and can have dependencies.]
>      > >
>      > > For this specific issue, my thought is that we should indeed
>      move compat.h
>      > > into EAL, but also add the EAL common/include/ path to the
>      global include
>      > > path for the project, so all EAL headers (e.g. including those
>      with defines
>      > > for cacheline size, and other common macros) are just always
>      available.
>      > > Libs like kvargs and others should be able to use RTE_DIM etc.
>      for
>      > > consistency with the rest of DPDK.
>      > >
>      > > /Bruce
>      > >
>      >
>      > Patches welcome so! :)
>      >
>      Working on it... :-)
> 
>    I don't think it is that quick to do, so, for the time being, do we go
>    with this patch ?
>    --
>    David Marchand
> 
While I'm not splitting EAL up, I have got a working patch for merging
compat into EAL, and it seems to build ok for meson and ninja. I'll send it
out shortly once I finish my final cleanup and checks on it. Incidentally,
it doesn't appear that compat is used by kvargs, despite it being listed as
a dependency of it.

/Bruce