From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id DA93A1B5E9 for <dev@dpdk.org>; Thu, 10 Jan 2019 11:48:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 02:48:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="117026384" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga003.jf.intel.com with SMTP; 10 Jan 2019 02:48:40 -0800 Received: by (sSMTP sendmail emulation); Thu, 10 Jan 2019 10:48:39 +0000 Date: Thu, 10 Jan 2019 10:48:39 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org Message-ID: <20190110104839.GB4728@bricha3-MOBL.ger.corp.intel.com> References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <1557339.2CBSiR8abE@xps> <b767da98-9c78-58e1-cd9d-97bd2dea9470@intel.com> <2632071.H5f8aPozaM@xps> <20190110100220.GA13196@bricha3-MOBL.ger.corp.intel.com> <dab5da59-db4a-8596-08bb-08b61eafbf3b@intel.com> <20190110104135.GA4728@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8xCZdV_SE1J281wAXDL_az=ojPqqfprA4eqxVC1aAStww@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJFAV8xCZdV_SE1J281wAXDL_az=ojPqqfprA4eqxVC1aAStww@mail.gmail.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 Jan 2019 10:48:44 -0000 On Thu, Jan 10, 2019 at 11:44:07AM +0100, David Marchand wrote: > On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Thu, Jan 10, 2019 at 10:34:19AM +0000, Burakov, Anatoly wrote: > > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: > > > I also forgot that. However, that does bring up the thought that > for some > > > of our headers we may want them available for all libraries even > before EAL > > > is compiled up. [I think this hits on the idea Thomas was > discussing of > > > splitting EAL up into two, where we have a core part that is > always > > > compiled first and has no dependencies followed by another which > is built > > > later and can have dependencies.] > > > > > > For this specific issue, my thought is that we should indeed > move compat.h > > > into EAL, but also add the EAL common/include/ path to the > global include > > > path for the project, so all EAL headers (e.g. including those > with defines > > > for cacheline size, and other common macros) are just always > available. > > > Libs like kvargs and others should be able to use RTE_DIM etc. > for > > > consistency with the rest of DPDK. > > > > > > /Bruce > > > > > > > Patches welcome so! :) > > > Working on it... :-) > > I don't think it is that quick to do, so, for the time being, do we go > with this patch ? > -- > David Marchand > While I'm not splitting EAL up, I have got a working patch for merging compat into EAL, and it seems to build ok for meson and ninja. I'll send it out shortly once I finish my final cleanup and checks on it. Incidentally, it doesn't appear that compat is used by kvargs, despite it being listed as a dependency of it. /Bruce