From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 077571B63D for ; Thu, 10 Jan 2019 14:19:54 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 05:19:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="309267074" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga006.fm.intel.com with SMTP; 10 Jan 2019 05:19:51 -0800 Received: by (sSMTP sendmail emulation); Thu, 10 Jan 2019 13:19:50 +0000 Date: Thu, 10 Jan 2019 13:19:50 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Thomas Monjalon , "Burakov, Anatoly" Message-ID: <20190110131950.GA7312@bricha3-MOBL.ger.corp.intel.com> References: <20190110111104.56464-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 13:19:55 -0000 On Thu, Jan 10, 2019 at 01:53:20PM +0100, David Marchand wrote: > On Thu, Jan 10, 2019 at 1:28 PM David Marchand > <[1]david.marchand@redhat.com> wrote: > > On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson > <[2]bruce.richardson@intel.com> wrote: > > Since compat library is only a single header, we can easily move it > into > the EAL common headers instead of tracking it separately. The > downside of > this is that it becomes a little more difficult to have any libs > that are > built before EAL depend on it. Thankfully, this is not the case, so > there > are no big complications to the move. > However, to ensure that we don't later hit problems later with this, > we can > add EAL common headers folder to the global include list in the > meson build > which means that all common headers can be safely used by all > libraries, no > matter what their build order. > Signed-off-by: Bruce Richardson <[3]bruce.richardson@intel.com> > > Currently testing this patch, I just noticed some remaining traces of > librte_compat: > > Checked build with make and meson on rhel7. > -- > David Marchand > Thanks, I'll check those out and do a V2. /Bruce