From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id D5C311B73F; Thu, 10 Jan 2019 18:28:12 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id b11so12063558wmj.1; Thu, 10 Jan 2019 09:28:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fgiUnHziF7T0ty0PnNtW0OxwoqghPJx8QgNLM8EBvSs=; b=ZHGYhZiGdnOQBw8cZbQUp87j+AerRW1+ASTy84S9+aAPqDZRntcWfZrPIcDF1esntg eJMVH+Ttte2IRrGrlneBdOrtuGnH1Hn9f0k1y/7lotOnKI6XkEouxnaYOVXzAikRs+YA xcyx/zsHUzMk2EgGLP7hDYKPrijdb2ef670TgMCOhD5ktpaHrmQBkHhSP5nzyVodT/JX qDMiOk2z6tL4yhzVkMhiX4nPorfb7HsXk3k2wZ2E19Qq4iqTQQUYZ8BOu9oDrXtGyOqV FPGU6sndKpn8UB0rzSNFGldqpGTcU449DzvA7sqmlK5wNjLjXMjqCZWvuQYLf6XjWx64 sNuQ== X-Gm-Message-State: AJcUukc+xNmhq88xU1gLZ89nlPu/fSxLBj3egtpToMuwYhadDrIiNLpQ mvvaLFAYKtedN6xt7SpUUudMNpWJRjA= X-Google-Smtp-Source: ALg8bN7hmdns6V3IYK1l8vPCzeQC0V46RRRtNy/gUi8B1kr7+Wmim2xJebS51kZqncSvhzZblevC+w== X-Received: by 2002:a7b:c1d7:: with SMTP id a23mr10143006wmj.48.1547141291997; Thu, 10 Jan 2019 09:28:11 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id k3sm96477438wrm.7.2019.01.10.09.28.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 09:28:11 -0800 (PST) From: Luca Boccassi To: dev@dpdk.org Cc: bruce.richardson@intel.com, christian.ehrhardt@canonical.com, Luca Boccassi , stable@dpdk.org Date: Thu, 10 Jan 2019 17:28:06 +0000 Message-Id: <20190110172806.12952-1-bluca@debian.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 17:28:13 -0000 Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers. This might cause problems, especially in distributions, so add a note in the pkg-config description. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi --- At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good. meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index f87dc235f..35126106a 100644 --- a/meson.build +++ b/meson.build @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), libraries: dpdk_libraries, libraries_private: dpdk_drivers + dpdk_static_libraries + ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, - description: 'The Data Plane Development Kit (DPDK)', + description: '''The Data Plane Development Kit (DPDK). +Note that CFLAGS might contain an -march flag higher than typical baseline. +This is required for a number of static inline functions in the public headers.''', subdirs: [get_option('include_subdir_arch'), '.'], extra_cflags: ['-include', 'rte_config.h'] + machine_args ) -- 2.20.1