From: Yongseok Koh <yskoh@mellanox.com> To: olivier.matz@6wind.com, shahafs@mellanox.com Cc: dev@dpdk.org, roszenrami@gmail.com, david.marchand@redhat.com Subject: [dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address Date: Thu, 10 Jan 2019 14:40:29 -0800 Message-ID: <20190110224030.2671-1-yskoh@mellanox.com> (raw) In-Reply-To: <20190109085426.39965-1-yskoh@mellanox.com> This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns the default address of mbuf data taking the headroom into account. Signed-off-by: Yongseok Koh <yskoh@mellanox.com> --- Please ignore v3, there were errors with some compilers. v4: * fix compilation error due to the experimental tag * add warning of experimental tag to the comments v3: * rename functions v2: * initial implementation lib/librte_mbuf/rte_mbuf.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index bc562dc8a9..5787616999 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -788,8 +788,54 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi) } /** + * Return the default buffer address of the mbuf. + * + * @warning + * @b EXPERIMENTAL: This API may change without prior notice. + * This will be used by rte_mbuf_to_baddr() which has redundant code once + * experimental tag is removed. + * + * @param mb + * The pointer to the mbuf. + * @param mp + * The pointer to the mempool of the mbuf. + * @return + * The pointer of the mbuf buffer. + */ +static inline char * __rte_experimental +rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool *mp) +{ + char *buffer_addr; + + buffer_addr = (char *)mb + sizeof(*mb) + rte_pktmbuf_priv_size(mp); + return buffer_addr; +} + +/** + * Return the default address of the beginning of the mbuf data. + * + * @warning + * @b EXPERIMENTAL: This API may change without prior notice. + * + * @param mb + * The pointer to the mbuf. + * @return + * The pointer of the beginning of the mbuf data. + */ +static inline char * __rte_experimental +rte_mbuf_data_addr_default(struct rte_mbuf *mb) +{ + return rte_mbuf_buf_addr(mb, mb->pool) + RTE_PKTMBUF_HEADROOM; +} + +/** * Return the buffer address embedded in the given mbuf. * + * @note: Accessing mempool pointer of a mbuf is expensive because the + * pointer is stored in the 2nd cache line of mbuf. If mempool is known, it + * is better not to reference the mempool pointer in mbuf but calling + * rte_mbuf_buf_addr() would be more efficient. + * * @param md * The pointer to the mbuf. * @return -- 2.11.0
next prev parent reply other threads:[~2019-01-10 22:40 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-09 8:54 [dpdk-dev] [PATCH] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-09 9:38 ` David Marchand 2019-01-09 9:52 ` Olivier Matz 2019-01-09 9:56 ` Yongseok Koh 2019-01-09 10:05 ` David Marchand 2019-01-09 10:11 ` Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-09 13:46 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address David Marchand 2019-01-10 1:39 ` Rami Rosen 2019-01-10 18:18 ` Yongseok Koh 2019-01-10 18:22 ` Yongseok Koh 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 " Yongseok Koh 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-10 19:10 ` Shahaf Shuler 2019-01-11 8:14 ` [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address Andrew Rybchenko 2019-01-11 11:03 ` Yongseok Koh 2019-01-11 11:17 ` Andrew Rybchenko 2019-01-11 11:37 ` Yongseok Koh 2019-01-11 11:57 ` Bruce Richardson 2019-01-11 12:48 ` David Marchand 2019-01-14 15:51 ` Olivier Matz 2019-01-10 22:40 ` Yongseok Koh [this message] 2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-11 8:05 ` [dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address Olivier Matz 2019-01-11 8:11 ` David Marchand 2019-01-11 8:32 ` David Marchand 2019-01-11 11:09 ` Yongseok Koh 2019-01-11 10:25 ` Thomas Monjalon 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning " Yongseok Koh 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-02-06 15:54 ` Kevin Traynor 2019-02-21 19:10 ` Kevin Traynor 2019-03-08 2:05 ` Yongseok Koh 2019-01-15 1:35 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190110224030.2671-1-yskoh@mellanox.com \ --to=yskoh@mellanox.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=olivier.matz@6wind.com \ --cc=roszenrami@gmail.com \ --cc=shahafs@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git