DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jens Freimann <jfreimann@redhat.com>
To: dev@dpdk.org
Cc: tiwei.bie@intel.com, maxime.coquelin@redhat.com
Subject: [dpdk-dev] [PATCH v4 0/2] net/virtio-user: add packed vq support
Date: Fri, 11 Jan 2019 10:39:27 +0100	[thread overview]
Message-ID: <20190111093929.10162-1-jfreimann@redhat.com> (raw)

Patch 1 fixes a bug in virtio_pq_send_command(). When we wait for
a descriptor to be marked as used we need to consider that the ring
might have wrapped and use the previous wrap counter.

Patch 2 reverts the patch to error out when cq is used with packed vq and
add support for packed virtqueues in control virtqueue code.

v3->v4:
 * it's enough to add to add packed vq feature bit to
   unsupported_features if packed_vq=0, no need to explicitly add
   it to device_features (Tiwei) 

v2->v3:
 * squash revert patch into patch 2
 * add new patch 1 to fix a bug in driver code
 * fix wrap handling code in virtio_user_handle_cq_packed
 * in v2 I was using wrap counters and indexes from shared virtqueue,
   fixed this and added wrap counters and used index to virtio_user code
 * tested wrap around of ring

v1->v2:
 * split into two patches
 * handle ring wrap correctly
 * add to unsupported_features when packed_vq is 0

Jens Freimann (2):
  net/virtio: check head desc with correct wrap counter
  net/virtio-user: ctrl vq support for packed

 drivers/net/virtio/virtio_ethdev.c            |  11 +-
 .../net/virtio/virtio_user/virtio_user_dev.c  | 102 ++++++++++++++++--
 .../net/virtio/virtio_user/virtio_user_dev.h  |  15 ++-
 drivers/net/virtio/virtio_user_ethdev.c       |  56 +++++++++-
 drivers/net/virtio/virtqueue.h                |  10 +-
 5 files changed, 171 insertions(+), 23 deletions(-)

-- 
2.17.2

             reply	other threads:[~2019-01-11  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  9:39 Jens Freimann [this message]
2019-01-11  9:39 ` [dpdk-dev] [PATCH v4 1/2] net/virtio: check head desc with correct wrap counter Jens Freimann
2019-01-11  9:39 ` [dpdk-dev] [PATCH v4 2/2] net/virtio-user: ctrl vq support for packed Jens Freimann
2019-01-11 10:05 ` [dpdk-dev] [PATCH v4 0/2] net/virtio-user: add packed vq support Maxime Coquelin
2019-01-11 13:56 ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111093929.10162-1-jfreimann@redhat.com \
    --to=jfreimann@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).