From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com
 [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id E92251BB82
 for <dev@dpdk.org>; Fri, 11 Jan 2019 20:49:24 +0100 (CET)
Received: by mail-pf1-f195.google.com with SMTP id w73so7410164pfk.10
 for <dev@dpdk.org>; Fri, 11 Jan 2019 11:49:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=rXPWtkHZLKzYML2qjSEktu9NBmMkbzQzD5bpvtn5RJY=;
 b=zYJ54tVlKq0oVOyWEP6fPDV4RUkvZ64iE3zHOS3jeGunvO7GyY+/H/jwxWUc2x8GxF
 Eyo6UsfkBE/zivURboRkeCqc2kKSzpOWDYgPkKrIVBFvoKyGoYF5AM2ZdFpXbcWz7ii/
 iYgRzG3iAGH9KAfxdEdpA1Us+zXXMkXRDTy8vfjdXFQA8RTnKPci3CUH2ZdT+9UfGZ/B
 HqO1PnDR8r6bWyVvCCVzir7IWmAc+fXHv7cTe17vEF9QNeHAOIN0n7qfsIXsHnQwm7+S
 kCAd1jRbHbZy3DET7XkQULFeiXnJD/jluQksH3+NTViK2JK6xDzLaamSQoxOYeKgXNUN
 D8mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=rXPWtkHZLKzYML2qjSEktu9NBmMkbzQzD5bpvtn5RJY=;
 b=lxSNmEUZDMafW9Jr7UU9y8uTFUx9OTuE6aDW3V79YYt+wr0lAwjipPqNJl/Nohf4vX
 UMR4xPLPtSTvDtWiFVw+sUkEBLHlPJpE6fFCHVusM+S4qag38z4rP8W8XzJPsu8wAs90
 OS8DNE4ngI3Ia7czQUcE2WCobckdR3il5lvZpSaHXzcTgRqOE8KFRw5tAaZYK86zG3oM
 YQ6DdnmBM5gt8WJ8wl3LEvdQt4HM48en+6ZhQVBYvVcUyAA62xMYRDPCdN2/utqJqmPO
 0aqccQf3yxHAxtokGnBQ7VqIFwAsbeXfVr8EdpCrkQCjTHMnIBDF/Y4gq8U2ArYZw+HF
 bnxw==
X-Gm-Message-State: AJcUukf1mDFPOTJd3NEub3WVEkmER82+rO2lnROqcJErtzIsle4yFb5D
 CmxrRyRwaLUnnVdAUee4FhHkPhH1ljQ=
X-Google-Smtp-Source: ALg8bN5zrwzmTd+Tkqukb6Ngv9MRBUWgOrneW9M5a9fFqwgl7PBeZtqX5GF1rEfe76fu6/+knDjj6w==
X-Received: by 2002:a63:d5e:: with SMTP id 30mr14635550pgn.54.1547236164093;
 Fri, 11 Jan 2019 11:49:24 -0800 (PST)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id h64sm125144995pfc.142.2019.01.11.11.49.23
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 11 Jan 2019 11:49:24 -0800 (PST)
Date: Fri, 11 Jan 2019 11:49:17 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20190111114917.06da84bb@hermes.lan>
In-Reply-To: <14FED5CB-5C2B-452D-BD47-6303EF67F90A@intel.com>
References: <20190111180659.5972-1-stephen@networkplumber.org>
 <20190111180659.5972-4-stephen@networkplumber.org>
 <14FED5CB-5C2B-452D-BD47-6303EF67F90A@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 19:49:25 -0000

On Fri, 11 Jan 2019 19:37:00 +0000
"Wiles, Keith" <keith.wiles@intel.com> wrote:

> > +/* make sure name is a possible Linux network device name */
> > +static bool is_valid_iface(const char *name)  
> 
> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states.

I am surprised because most of the DPDK follows kernel style.
And in kernel style one line is preferred if line is not too long.