From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130087.outbound.protection.outlook.com [40.107.13.87]) by dpdk.org (Postfix) with ESMTP id EA1441BB69; Fri, 11 Jan 2019 13:24:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2KefYBuRuHKcRHY+K+80jpe/WWrJogeZIOmtopG2lQU=; b=fFU03zmENhCRMW9nQRqOvtlzuZlaDymSbxVDbO+dO2zuBlMZxFujv0EMLHdcqKO8N/oF38YB34uZ622Il0PHYjqi/LZJd5O7uFxUOfhzUp8VwPAsRi4oefAmdhDoIcKi1O7QHv9w+Sy6DE1wUACuX5Q5Cg4c/LuVRDVESBpqnFM= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB5455.eurprd04.prod.outlook.com (20.178.121.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Fri, 11 Jan 2019 12:24:16 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::b1eb:7e7e:7b90:7b4]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016; Fri, 11 Jan 2019 12:24:16 +0000 From: Shreyansh Jain To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Hemant Agrawal , "stable@dpdk.org" Thread-Topic: [PATCH v3 04/19] net/dpaa2: fix bad check for not-null Thread-Index: AQHUqaiRFA+a9+TSW0WLrYmI04t0qw== Date: Fri, 11 Jan 2019 12:24:16 +0000 Message-ID: <20190111122305.7133-5-shreyansh.jain@nxp.com> References: <20190111115712.6482-1-shreyansh.jain@nxp.com> <20190111122305.7133-1-shreyansh.jain@nxp.com> In-Reply-To: <20190111122305.7133-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.254.130] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TY2PR01CA0017.jpnprd01.prod.outlook.com (2603:1096:404:a::29) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB5455; 6:RmI2EsF9S7pKSvyG4Agmt7hJmrDzVWyiFWOROaB21ODOEkSOJ4TeYOp0BroR/NCFFvhhldAcR7YUDPeELxJH/xVO97/UjlylAkTNHtTwQ7BJCbBDvGmDuxoAmmaw81usPIGjoPYEs5q9s7zOQv8XOyt1mTvZbo0PYFHwWJjFcSTdkQI4hsRwYS8ZMHc+Eib6mKSusxnkiAQ2U16iamQ+pRt06ejSJiR+eo6uZ/+vCy+FG9OkK4t37bodAn3ZNhRkOpOnuuEeW73/dXPc76plHlrtGeyK6DNQ7pgZCWcjBi84C1+JpAc4lAnBIn5b3lIZOYfEp9ilZdA7+mPYlqtWUkgkFzjf0zuOz5wSSnHlATjq8WLIAx/XsCN+I7QfNty19K/MuSGpoZ2b006vGzhAbNWNU23CYQywgii/svEIqvcaWYZ7esSEVI94nOVw4CcB97a0+tVUs7UvEVOVJ0Ec+g==; 5:HP02UOpestdpiAsG3qIVXgOyv9HnEoU9WLLfCQ4B57NrQJ4HAb1QevGgDjE3vgwruJ74FpoINjV23pKshOQYeVKSZzlM4cejEmtSXOXE4HGNGQ9mVecx6RQIeirQHSS4TSdMj3wRCqFTNaHnorryJrfrCOymzgkmKCvTFgihTMGPGY/8HP+Tvg7Rzuw0aHsLhLNNj6drGoYw72Uw3aSGYQ==; 7:ZknzDPK95JO34pO0KFzIpMLMs7J6nPxOAKFtSEHM4q5U/8qej2/uWQsdIFlJVpYlEroxc0XKF9aBfN0v1nQpi6n91YvxTkhhxlRDYSekbugSH1wL98CN7gtVrdV5ueT2q4urJ8utKk4hlyA+DizhuQ== x-ms-office365-filtering-correlation-id: 1a4c0486-adb9-4917-fccf-08d677bfb395 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB5455; x-ms-traffictypediagnostic: VI1PR04MB5455: x-microsoft-antispam-prvs: x-forefront-prvs: 09144DB0F7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(66066001)(186003)(86362001)(71200400001)(2351001)(71190400001)(55236004)(386003)(36756003)(6506007)(26005)(99286004)(105586002)(6116002)(106356001)(102836004)(2906002)(54906003)(5660300001)(3846002)(256004)(8936002)(4744005)(97736004)(78486014)(50226002)(2501003)(6486002)(305945005)(6436002)(14454004)(7736002)(8676002)(316002)(1730700003)(81166006)(81156014)(5640700003)(4326008)(2616005)(446003)(6916009)(478600001)(1076003)(52116002)(6512007)(44832011)(486006)(76176011)(53936002)(11346002)(68736007)(476003)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5455; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: iWiGzDywqIa4XGNPKMtEWAQAitIZ8bFc17GwlvZys6BTXriL5lZrn/JzbUTdQl0fc3NqJ7wczUFYgcBvQBhuHgdW3Lymg7cGRHPiIC6Hp99VzDqepzyR1n2npL46bAdUckKHyGo7NKGzhlM33lngHVgdyljCQxnjwfayK15DCYxp6egmRhpeCwc53hWS/OEBKdAxcnDWSmrYqJE58NAk17c3FOCfLi8kSHl4NjSSeevuViCpB3N6xLFggdi6DHy32mM4G0td54m7So+aGaytFxSwICNvGvJkq1q3yIVNEitw7dXeaPd9vg41gcfrURoBlHfsailLREGdR0JowAANoXxnbsd2gO5woLa+75IcCx8i8PjmJyVaGCdKjbpWriRR3wJ81CgbpNPxCE0ntYiO+4yF3y1jc25EYfGqtvsxs1g= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4c0486-adb9-4917-fccf-08d677bfb395 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2019 12:24:12.7425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5455 Subject: [dpdk-dev] [PATCH v3 04/19] net/dpaa2: fix bad check for not-null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 12:24:18 -0000 From: Hemant Agrawal The check !dpaa2->cscn is not correct to check non-null value. Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_eth= dev.c index fa71807e6..8d4ea1bca 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -311,8 +311,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev) /* cleanup tx queue cscn */ for (i =3D 0; i < priv->nb_tx_queues; i++) { dpaa2_q =3D (struct dpaa2_queue *)priv->tx_vq[i]; - if (!dpaa2_q->cscn) - rte_free(dpaa2_q->cscn); + rte_free(dpaa2_q->cscn); } /*free memory for all queues (RX+TX) */ rte_free(priv->rx_vq[0]); --=20 2.17.1