From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 772C11BBFB for ; Fri, 11 Jan 2019 14:58:32 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 05:58:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,465,1539673200"; d="scan'208";a="137408046" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2019 05:58:30 -0800 Date: Fri, 11 Jan 2019 21:56:17 +0800 From: Tiwei Bie To: Jens Freimann Cc: dev@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20190111135617.GB2026@dpdk-tbie.sh.intel.com> References: <20190111093929.10162-1-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190111093929.10162-1-jfreimann@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 0/2] net/virtio-user: add packed vq support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 13:58:32 -0000 On Fri, Jan 11, 2019 at 10:39:27AM +0100, Jens Freimann wrote: > Patch 1 fixes a bug in virtio_pq_send_command(). When we wait for > a descriptor to be marked as used we need to consider that the ring > might have wrapped and use the previous wrap counter. > > Patch 2 reverts the patch to error out when cq is used with packed vq and > add support for packed virtqueues in control virtqueue code. > > v3->v4: > * it's enough to add to add packed vq feature bit to > unsupported_features if packed_vq=0, no need to explicitly add > it to device_features (Tiwei) Sorry for not making myself clear previously. Just to make it clear to avoid more confusion: we shouldn't add it to device_features by ourselves because vhost backend may not support it. Otherwise, it's possible that the upper layer in virtio driver will see virtio-user's .get_features() report this feature while vhost backend doesn't support it. Thanks for the new version. > > v2->v3: > * squash revert patch into patch 2 > * add new patch 1 to fix a bug in driver code > * fix wrap handling code in virtio_user_handle_cq_packed > * in v2 I was using wrap counters and indexes from shared virtqueue, > fixed this and added wrap counters and used index to virtio_user code > * tested wrap around of ring > > v1->v2: > * split into two patches > * handle ring wrap correctly > * add to unsupported_features when packed_vq is 0 > > Jens Freimann (2): > net/virtio: check head desc with correct wrap counter > net/virtio-user: ctrl vq support for packed > > drivers/net/virtio/virtio_ethdev.c | 11 +- > .../net/virtio/virtio_user/virtio_user_dev.c | 102 ++++++++++++++++-- > .../net/virtio/virtio_user/virtio_user_dev.h | 15 ++- > drivers/net/virtio/virtio_user_ethdev.c | 56 +++++++++- > drivers/net/virtio/virtqueue.h | 10 +- > 5 files changed, 171 insertions(+), 23 deletions(-) > > -- > 2.17.2 >