From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BE70E1B9BE for ; Fri, 11 Jan 2019 16:50:35 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 07:50:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="133726944" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga002.fm.intel.com with SMTP; 11 Jan 2019 07:50:33 -0800 Received: by (sSMTP sendmail emulation); Fri, 11 Jan 2019 15:50:32 +0000 Date: Fri, 11 Jan 2019 15:50:32 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190111155032.GB10780@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111123809.8789-1-bluca@debian.org> <20190111123809.8789-3-bluca@debian.org> <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com> <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com> <1547219078.4501.16.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1547219078.4501.16.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 15:50:36 -0000 On Fri, Jan 11, 2019 at 03:04:38PM +0000, Luca Boccassi wrote: > On Fri, 2019-01-11 at 14:30 +0000, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote: > > > > Move libbsd inclusion to librte_eal, so that all other libraries > > > > and > > > > PMDs will inherit it, and librte_cmdline which is built before > > > > librte_eal. > > > > Bump Meson dependency to 0.47.1, to avoid bug where the linker > > > > flag of > > > > the dependency gets replicated again and again. > > > > > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > v2: bump meson minimum version to 0.47.1 to avoid meson bug, and > > > > move > > > >     libbsd dependency to eal and cmdline > > > > > > > >  config/meson.build             | 10 +++++----- > > > >  lib/librte_cmdline/meson.build |  4 ++++ > > > >  lib/librte_eal/meson.build     |  3 +++ > > > >  meson.build                    |  2 +- > > > >  4 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > > > There are some meson version checks in the code that can be removed > > > as > > > part of this change: > > > > > > $ git grep meson.version > > > drivers/meson.build:    if > > > meson.version().version_compare('>=0.47') > > > kernel/linux/meson.build:       if > > > meson.version().version_compare('>=0.44') > > > kernel/linux/meson.build:               if > > > meson.version().version_compare('>=0.44') > > > meson.build:    meson_version: '>= 0.41' > > > meson.build:if meson.version().version_compare('>=0.47') > > > > > > > Thinking on this more, I think the version bump to 0.47 should be > > done in a > > separate standalone patch at the start of this set. Then the other > > patches > > can be based on that. > > > > /Bruce > > Ok, will remove those checks in v3 and move the bump to a different > patch. I'll put it second, as the first patch is really not related to > the version and it's stand-alone (and marked for stable), I was just > too lazy to do 2 series :-) > > -- > Kind regards, > Luca Boccassi I don't expect the version bump to happen for 19.02, so if you want the first patch to go into that release, it probably needs to be standalone. /Bruce