From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4E4FD1B9F1 for ; Fri, 11 Jan 2019 18:22:20 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 09:22:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="311072158" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by fmsmga005.fm.intel.com with SMTP; 11 Jan 2019 09:22:18 -0800 Received: by (sSMTP sendmail emulation); Fri, 11 Jan 2019 17:22:17 +0000 Date: Fri, 11 Jan 2019 17:22:17 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190111172217.GC16340@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111162608.13162-1-bluca@debian.org> <20190111162608.13162-3-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111162608.13162-3-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v3 3/4] build: reorder libraries and build eal before cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 17:22:21 -0000 On Fri, Jan 11, 2019 at 04:26:07PM +0000, Luca Boccassi wrote: > Most libraries and PMDs depend on eal, and eal depends only on kvargs, > so reorder the list in Meson to reflect this and take advantage of this > dependency chain. > > Signed-off-by: Luca Boccassi > --- > v3: added this patch to let the next just update librte_eal instead of > also having to update rte_cmdline > > lib/meson.build | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/meson.build b/lib/meson.build > index a2dd52e17..bf8417c6d 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -9,9 +9,10 @@ > # given as a dep, no need to mention ring. This is especially true for the > # core libs which are widely reused, so their deps are kept to a minimum. > libraries = [ 'compat', # just a header, used for versioning > - 'cmdline', # ethdev depends on cmdline for parsing functions > 'kvargs', # eal depends on kvargs > - 'eal', 'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core > + 'eal', # everything depends on eal > + 'cmdline', # ethdev depends on cmdline for parsing functions > + 'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core > 'metrics', # bitrate/latency stats depends on this > 'hash', # efd depends on this > 'timer', # eventdev depends on this This is a saner build order, so Acked-by: Bruce Richardson