From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id BB7011BBEA for ; Fri, 11 Jan 2019 21:35:38 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id w4so7253649plz.1 for ; Fri, 11 Jan 2019 12:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vJJzFZ2cAE6qSxCsYmoxT2HhCf+hA6uFX8h8hCmJn9w=; b=lTFHrnmrsNF0LudZgxZKgYc0hrtRRkhDmwz9zrUKjiambr8h1bcTF84ubKn+i4epOY 6zsY9Nbu8y8/cqvEygU7MzeJVv5HthSPQFv3XXOIu5yHqidbU5iPtDzAb1udEPdkVAKX 2nHFtQ+jjqUgys21hDoUKF8uCEWShmqK5bFTLlphZzZkTt6T411++AbqNjMgw+JJZ1ZU 6O9vhakoDldexdmrDlTV83SKWmVP36v5w+q8ns7QaHJ0WdhQCz2ct+MsWCd4w16qJBOY RnMWV2REkYdUR3WDvZgAezKuCedNiZ7GnBP4/42r8gk33xyKADvXW5QOkRwbCdug+hXR tACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vJJzFZ2cAE6qSxCsYmoxT2HhCf+hA6uFX8h8hCmJn9w=; b=QKQ5NxC7Gh4kfpG0aBAANzB2w9myJrheWagVZ9pDZgcjxnAz97CVFJqNoSi1o34z40 +0L4GnKDsoLleev/DlI5BmG9AtklzCOKSZWO0b4FTrhjHgZSNN9yrFnehDQmBTDaykIQ WyEWn8eib/xwfnLvz95CsXHlzRSwJfuBcq0mRBo7ZA7I7YtjzOP3r8NN6YxuzEnGnyV6 p24m8hJPzWm2asEBB8TxbA3pTfcdSwrewH++vqPZOxWwSiqeOj4pBOqs2BJOEfRWyig9 /eRqxdQC8dJd0VwLpQcoy4iUJuuZQENoX6eys5tPZC+z7MynaKxbFWJqJ65VGDLOsycu +8ug== X-Gm-Message-State: AJcUukciev6Fkvt8PVzMfW+egHqecRipGtXJj4vvSYeH0O0a0r5sD1j/ hnkVl/5QU8gPfur1YILqUTpJDw== X-Google-Smtp-Source: ALg8bN7S6b0RwiVna6CDjh+ZCEl1w2ei7zub4Uxciyg0tIuetXJfomhWnN0AsRzadn58IH39mEM9ww== X-Received: by 2002:a17:902:6b09:: with SMTP id o9mr16009976plk.208.1547238937958; Fri, 11 Jan 2019 12:35:37 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f32sm96610438pgf.80.2019.01.11.12.35.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 12:35:36 -0800 (PST) From: Stephen Hemminger To: keith.wiles@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 11 Jan 2019 12:35:20 -0800 Message-Id: <20190111203520.19944-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111203520.19944-1-stephen@networkplumber.org> References: <20190111180659.5972-1-stephen@networkplumber.org> <20190111203520.19944-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 20:35:39 -0000 Printing pointer in log is uninformative (unless in a debugger), instead print the assigned kernel device name which correlates well with what TAP is doing. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 705c90dadee5..586c8a952df9 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -853,6 +853,8 @@ tap_dev_stop(struct rte_eth_dev *dev) static int tap_dev_configure(struct rte_eth_dev *dev) { + struct pmd_internals *pmd = dev->data->dev_private; + if (dev->data->nb_rx_queues > RTE_PMD_TAP_MAX_QUEUES) { TAP_LOG(ERR, "%s: number of rx queues %d exceeds max num of queues %d", @@ -870,11 +872,11 @@ tap_dev_configure(struct rte_eth_dev *dev) return -1; } - TAP_LOG(INFO, "%s: %p: TX configured queues number: %u", - dev->device->name, (void *)dev, dev->data->nb_tx_queues); + TAP_LOG(INFO, "%s: %s: TX configured queues number: %u", + dev->device->name, pmd->name, dev->data->nb_tx_queues); - TAP_LOG(INFO, "%s: %p: RX configured queues number: %u", - dev->device->name, (void *)dev, dev->data->nb_rx_queues); + TAP_LOG(INFO, "%s: %s: RX configured queues number: %u", + dev->device->name, pmd->name, dev->data->nb_rx_queues); return 0; } -- 2.20.1