From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
xiao.w.wang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function
Date: Sat, 12 Jan 2019 09:01:59 +0800 [thread overview]
Message-ID: <20190112010159.GA100283@intel.com> (raw)
In-Reply-To: <20190111133141.GA2026@dpdk-tbie.sh.intel.com>
On 01/11, Tiwei Bie wrote:
>> vhost_user: remove statement for non-existed function
>
>s/vhost_user/vhost/
>
>On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
>> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
>> header file should be removed accordingly.
>>
>> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
>> Cc: xiao.w.wang@intel.com
>> Cc: stable@dpdk.org
>
>There is no need to cc stable, because above commit is part
>of 19.02 which hasn't been released yet.
>
>For the rest,
>Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?
Thanks,
Xiaolong
>
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> lib/librte_vhost/vhost_user.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
>> index dc97be843..2a650fe4b 100644
>> --- a/lib/librte_vhost/vhost_user.h
>> +++ b/lib/librte_vhost/vhost_user.h
>> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>> /* vhost_user.c */
>> int vhost_user_msg_handler(int vid, int fd);
>> int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
>> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>>
>> /* socket.c */
>> int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2019-01-12 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:05 Xiaolong Ye
2019-01-11 13:31 ` Tiwei Bie
2019-01-12 1:01 ` Ye Xiaolong [this message]
2019-01-15 6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
2019-01-15 6:49 ` Tiwei Bie
2019-01-17 11:33 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112010159.GA100283@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).