From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9BEED1B8CB; Sat, 12 Jan 2019 02:01:45 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 17:01:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,467,1539673200"; d="scan'208";a="133856060" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga002.fm.intel.com with ESMTP; 11 Jan 2019 17:01:42 -0800 Date: Sat, 12 Jan 2019 09:01:59 +0800 From: Ye Xiaolong To: Tiwei Bie Cc: dev@dpdk.org, Maxime Coquelin , xiao.w.wang@intel.com, stable@dpdk.org Message-ID: <20190112010159.GA100283@intel.com> References: <20190111080541.96774-1-xiaolong.ye@intel.com> <20190111133141.GA2026@dpdk-tbie.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111133141.GA2026@dpdk-tbie.sh.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2019 01:01:46 -0000 On 01/11, Tiwei Bie wrote: >> vhost_user: remove statement for non-existed function > >s/vhost_user/vhost/ > >On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote: >> vhost_user_host_notifier_ctrl is not existed anymore, its statement in >> header file should be removed accordingly. >> >> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl") >> Cc: xiao.w.wang@intel.com >> Cc: stable@dpdk.org > >There is no need to cc stable, because above commit is part >of 19.02 which hasn't been released yet. > >For the rest, >Reviewed-by: Tiwei Bie Thanks for the review. In this kind of case, I suppose there is no need to reroll the patch, right? Thanks, Xiaolong > >> >> Signed-off-by: Xiaolong Ye >> --- >> lib/librte_vhost/vhost_user.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h >> index dc97be843..2a650fe4b 100644 >> --- a/lib/librte_vhost/vhost_user.h >> +++ b/lib/librte_vhost/vhost_user.h >> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg { >> /* vhost_user.c */ >> int vhost_user_msg_handler(int vid, int fd); >> int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm); >> -int vhost_user_host_notifier_ctrl(int vid, bool enable); >> >> /* socket.c */ >> int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds, >> -- >> 2.17.1 >>