From: Yongseok Koh <yskoh@mellanox.com>
To: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com
Cc: dev@dpdk.org, qi.z.zhang@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap
Date: Mon, 14 Jan 2019 02:00:21 -0800 [thread overview]
Message-ID: <20190114100022.14867-1-yskoh@mellanox.com> (raw)
The pointer is misused and could set wrong MAC address. As a result, some
of packets can be dropped in receiver side due to MAC address mismatch.
This can be shown as performance degradation.
Bugzilla ID: 188
Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86")
Cc: qi.z.zhang@intel.com
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
app/test-pmd/macswap_sse.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h
index 7d268bfbb0..662fe79cf9 100644
--- a/app/test-pmd/macswap_sse.h
+++ b/app/test-pmd/macswap_sse.h
@@ -76,7 +76,7 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb,
eth_hdr[0] = rte_pktmbuf_mtod(mb[0], struct ether_hdr *);
/* Swap dest and src mac addresses. */
- addr0 = _mm_loadu_si128((__m128i *)eth_hdr);
+ addr0 = _mm_loadu_si128((__m128i *)eth_hdr[0]);
addr0 = _mm_shuffle_epi8(addr0, shfl_msk);
_mm_storeu_si128((__m128i *)eth_hdr[0], addr0);
--
2.11.0
next reply other threads:[~2019-01-14 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 10:00 Yongseok Koh [this message]
2019-01-14 10:00 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix missing prefetch in macswap mode Yongseok Koh
2019-01-14 13:40 ` Iremonger, Bernard
2019-01-14 13:39 ` [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap Iremonger, Bernard
2019-01-14 14:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114100022.14867-1-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).